1484117 - Split HTMLEditor::InsertTableRow() for internal use

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f38b1c9739386bd2e63d120d410603ec2a52f875

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1484117 - part 0: Add automated tests for nsITableEditor.insertTableRow()

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1484117 - part 1: Create HTMLEditor::InsertTableRowsWithTransaction() for internal use of nsITableEditor::InsertTableRow()

nsITableEditor::InsertTableRow() is an XPCOM method but there are some internal
users.  So, HTMLEditor should implement it with a non-virtual method and
it should be used by all internal users.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=990e8091ec9e2eaeae1e8973eb9a8bcd5f2d07a1

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 9010006 [details]
Bug 1484117 - part 0: Add automated tests for nsITableEditor.insertTableRow()

Makoto Kato [:m_kato] has approved the revision.

Comment 6

[Makoto Kato [:m_kato]]

Comment on attachment 9010007 [details]
Bug 1484117 - part 1: Create HTMLEditor::InsertTableRowsWithTransaction() for internal use of nsITableEditor::InsertTableRow()

Makoto Kato [:m_kato] has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ede1caad7306
part 1: Create HTMLEditor::InsertTableRowsWithTransaction() for internal use of nsITableEditor::InsertTableRow() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/d5e804da423c
part 0: Add automated tests for nsITableEditor.insertTableRow() r=m_kato

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/ede1caad7306
https://hg.mozilla.org/mozilla-central/rev/d5e804da423c