1484120 - Split HTMLEditor::DeleteTableCellContents() for internal use

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=607ab4cbba2d4ac7d9b1ed2dda5593fd059e4ae0

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1484120 - part 0: Add automated tests for nsITableEditor.deleteTableCellContents.html

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1484120 - part 1: Create HTMLEditor::DeleteTableCellContentsWithTransaction() for internal use of nsITableEditor::DeleteTableCellContents()

nsITableEditor::DeleteTableCellContents() is an XPCOM method but it's used
internally.  So, HTMLEditor should implement it with a non-virtual method
and all internal users should use the non-virtual method instead.

This patch adds HTMLEditor::DeleteTableCellContentsWithTransaction() for that.
Additionally, this patch renames its helper method DeleteCellContents() to
DeleteAllChidlrenWithTransaction() and moves it to HTMLEditor.cpp since it can
handle any element nodes.

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 9009997 [details]
Bug 1484120 - part 0: Add automated tests for nsITableEditor.deleteTableCellContents.html

Makoto Kato [:m_kato] has approved the revision.

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 9010002 [details]
Bug 1484120 - part 1: Create HTMLEditor::DeleteTableCellContentsWithTransaction() for internal use of nsITableEditor::DeleteTableCellContents()

Makoto Kato [:m_kato] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e13d82e0536
part 0: Add automated tests for nsITableEditor.deleteTableCellContents.html r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ca674e42cbca
part 1: Create HTMLEditor::DeleteTableCellContentsWithTransaction() for internal use of nsITableEditor::DeleteTableCellContents() r=m_kato

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1e13d82e0536
https://hg.mozilla.org/mozilla-central/rev/ca674e42cbca