1484122 - Split HTMLEditor::DeleteTableRow() for internal use

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c0da4d1b2fa4b0bad38565427714963f55d485c5

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ad4018494432e7be731c731fd05f08851af6621

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1484122 - part 0: Add automated tests for nsITableEditor.deleteTableRow.html

This patch changes a bit in HTMLEditor::DeleteTableRow() because calling
DeleteTable2() without those helper classes hits MOZ_ASSERT().

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1484122 - part 1: Create HTMLEditor::DeleteSelectedTableRowsWithTransaction() for internal use of nsITableEditor::DeleteTableRow()

nsITableEditor::DeleteTableRow() is an XPCOM method but there are some internal
users.  So, it should be implemented as non-virtual protected method and
internal users should use it instead.

This also renames (and reimplement) HTMLEditor::DeleteTable2() since it's
really bad name and the code dispatches unnecessary "selectionchange" events.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1484122 - part 2: Clean up HTMLEditor::DeleteRow()

This patch renames HTMLEditor::DeleteRow() to
HTMLEditor::DeleteTableRowWithTransaction() and cleans up its implementation.

Comment 6

[Makoto Kato [:m_kato]]

Comment on attachment 9009319 [details]
Bug 1484122 - part 0: Add automated tests for nsITableEditor.deleteTableRow.html

Makoto Kato [:m_kato] has approved the revision.

Comment 7

[Makoto Kato [:m_kato]]

Comment on attachment 9009320 [details]
Bug 1484122 - part 1: Create HTMLEditor::DeleteSelectedTableRowsWithTransaction() for internal use of nsITableEditor::DeleteTableRow()

Makoto Kato [:m_kato] has approved the revision.

Comment 8

[Makoto Kato [:m_kato]]

Comment on attachment 9009321 [details]
Bug 1484122 - part 2: Clean up HTMLEditor::DeleteRow()

Makoto Kato [:m_kato] has approved the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9913556f42c1
part 0: Add automated tests for nsITableEditor.deleteTableRow.html r=m_kato

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e2fe3f19c3c
part 1: Create HTMLEditor::DeleteSelectedTableRowsWithTransaction() for internal use of nsITableEditor::DeleteTableRow() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b240ef0f3694
part 2: Clean up HTMLEditor::DeleteRow() r=m_kato

Comment 11

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/9913556f42c1
https://hg.mozilla.org/mozilla-central/rev/7e2fe3f19c3c
https://hg.mozilla.org/mozilla-central/rev/b240ef0f3694