1484125 - Split HTMLEditor::GetTableSize() for internal use

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1484125 - part 0: Add automated tests for nsITableEditor::GetTableSize()

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah, I realized that part 1 can be simpler than now. I'll attach part.1 later.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6b51dd7257d557fdcc0dcd3097c362decc8d096

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1484125 - part 1: Create TableSize struct to compute and store number of rows and columns of a <table> element

HTMLEditor::GetTableSize() is an XPCOM method but used internally a lot.
Therefore, it shouldn't be called for internal use.  Additionally, the
callers need to declare two int32_t variables, but this causes the code
messy.  Therefore, this patch creates TableSize struct and it implements
HTMLEditor::GetTableSize().  Then, all callers of it is replaced with
TableSize struct.

New TableSize struct does not support computes <table> element from anchor
of Selection since there is no user of this in C++ code.

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 9003033 [details]
Bug 1484125 - part 0: Add automated tests for nsITableEditor::GetTableSize()

Makoto Kato [:m_kato] has approved the revision.

Comment 6

[Makoto Kato [:m_kato]]

Comment on attachment 9003037 [details]
Bug 1484125 - part 1: Create TableSize struct to compute and store number of rows and columns of a <table> element

Makoto Kato [:m_kato] has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c0edfef06dd
part 0: Add automated tests for nsITableEditor::GetTableSize() r=m_kato

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cf8d56c3f33
part 1: Create TableSize struct to compute and store number of rows and columns of a <table> element r=m_kato

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5c0edfef06dd
https://hg.mozilla.org/mozilla-central/rev/3cf8d56c3f33