Closed Bug 1484125 Opened 2 years ago Closed 2 years ago

Split HTMLEditor::GetTableSize() for internal use

Categories

(Core :: DOM: Editor, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Ah, I realized that part 1 can be simpler than now. I'll attach part.1 later.
HTMLEditor::GetTableSize() is an XPCOM method but used internally a lot.
Therefore, it shouldn't be called for internal use.  Additionally, the
callers need to declare two int32_t variables, but this causes the code
messy.  Therefore, this patch creates TableSize struct and it implements
HTMLEditor::GetTableSize().  Then, all callers of it is replaced with
TableSize struct.

New TableSize struct does not support computes <table> element from anchor
of Selection since there is no user of this in C++ code.
Comment on attachment 9003033 [details]
Bug 1484125 - part 0: Add automated tests for nsITableEditor::GetTableSize()

Makoto Kato [:m_kato] has approved the revision.
Attachment #9003033 - Flags: review+
Comment on attachment 9003037 [details]
Bug 1484125 - part 1: Create TableSize struct to compute and store number of rows and columns of a <table> element

Makoto Kato [:m_kato] has approved the revision.
Attachment #9003037 - Flags: review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/5c0edfef06dd
part 0: Add automated tests for nsITableEditor::GetTableSize() r=m_kato
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/3cf8d56c3f33
part 1: Create TableSize struct to compute and store number of rows and columns of a <table> element r=m_kato
https://hg.mozilla.org/mozilla-central/rev/5c0edfef06dd
https://hg.mozilla.org/mozilla-central/rev/3cf8d56c3f33
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.