Closed Bug 1484127 Opened 2 years ago Closed 2 years ago

Split HTMLEditor::GetCellAt() for internal use

Categories

(Core :: DOM: Editor, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
nsITableEditor::GetCellAt() is an XPCOM method, but this is called internally
a lot.  So, we should create non-virtual method for internal use.

The XPCOM method retrieves a <table> element if given element is nullptr.
However, no internal user needs this feature.  So, we can create
GetTableCellElementAt() simply.  Then, we can get rid of nsresult and
ErrorResult from it.
Comment on attachment 9003039 [details]
Bug 1484127 - part 0: Add automated tests for nsITableEditor::GetCellAt()

Makoto Kato [:m_kato] has approved the revision.
Attachment #9003039 - Flags: review+
Comment on attachment 9003040 [details]
Bug 1484127 - part 1: Create HTMLEditor::GetTableCellElementAt() for internal use of nsITableEditor::GetCellAt()

Makoto Kato [:m_kato] has approved the revision.
Attachment #9003040 - Flags: review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/b95c3522fa1e
part 0: Add automated tests for nsITableEditor::GetCellAt() r=m_kato
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/3d27e4213ccc
part 1: Create HTMLEditor::GetTableCellElementAt() for internal use of nsITableEditor::GetCellAt() r=m_kato
https://hg.mozilla.org/mozilla-central/rev/b95c3522fa1e
https://hg.mozilla.org/mozilla-central/rev/3d27e4213ccc
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.