Closed
Bug 1484129
Opened 6 years ago
Closed 6 years ago
Split HTMLEditor::GetNextSelectedCell() for internal use
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8bd7359d59a703553f0dcc0ce10dbff4c0597c5a
|
|
Assignee | |
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f23225ec34364b5733bd069aefea25d81ba738f1
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=87fa087d63f8296a38aae60f3403fd902a11fa92
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
|
Assignee | |
Comment 5•6 years ago
|
||
nsITableEditor::GetNextCellElement() is an XPCOM method but it's used internally a lot. So, HTMLEditor should implement it with non-virtual method and internal users should use the non-virtual method. Therefore, this patch creates HTMLEditor::GetNextSelectedTableCellElement().
|
||
Comment 6•6 years ago
|
||
Comment on attachment 9003723 [details] Bug 1484129 - part 1: Create HTMLEditor::GetNextSelectedTableCellElement() for internal use of nsITableEditor::GetNextCellElement() Makoto Kato [:m_kato] has approved the revision.
Attachment #9003723 -
Flags: review+
|
|
||
Comment 7•6 years ago
|
||
Comment on attachment 9003721 [details] Bug 1484129 - part 0: Add automated tests for nsITableEditor::GetNextSelectedCell() Makoto Kato [:m_kato] has approved the revision.
Attachment #9003721 -
Flags: review+
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/bfbee4aff230 part 0: Add automated tests for nsITableEditor::GetNextSelectedCell() r=m_kato
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/9da197304355 part 1: Create HTMLEditor::GetNextSelectedTableCellElement() for internal use of nsITableEditor::GetNextCellElement() r=m_kato
|
||
Comment 10•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bfbee4aff230 https://hg.mozilla.org/mozilla-central/rev/9da197304355
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
|
Assignee | |
Updated•6 years ago
|
Blocks: add-scriptable-editor-API-tests
You need to log in
before you can comment on or make changes to this bug.
Description
•