Closed Bug 1484136 Opened Last year Closed Last year

Split HTMLEditor::RefreshGrabber() for internal use

Categories

(Core :: Editor, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox63 --- wontfix
firefox64 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

Priority: -- → P3
HTMLEditor::RefereshGrabber() is an XPCOM method which is used by BlueGriffon.
Additionally, it's called internally.  Therefore, we should create a non-virtual
method for this and all internal users should use it.

This patch renames all other related methods to *Internal() for consistency.
Additionally, this fixes a bug of nested calls of ShowGrabber() and
HideGrabber().  This makes CreateGrabber() sets mGrabber directly since
it may be cleared by HideGrabber() while it's running, and also makes
HideGrabber() moves all members who will be cleaned up with local variables
and always clean them up even if it meats an error.
Comment on attachment 9007765 [details]
Bug 1484136 - Create HTMLEditor::RefreshGrabberInternal() for internal use

Makoto Kato [:m_kato] has approved the revision.
Attachment #9007765 - Flags: review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/cb28a4b17303
Create HTMLEditor::RefreshGrabberInternal() for internal use r=m_kato
https://hg.mozilla.org/mozilla-central/rev/cb28a4b17303
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.