1484136 - Split HTMLEditor::RefreshGrabber() for internal use

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfca3ed5ea539f46fcd7b81e867b33b2fb3e76da

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1529988b7e899c19865f11bcb21fbf7f842b94d9

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1484136 - Create HTMLEditor::RefreshGrabberInternal() for internal use

HTMLEditor::RefereshGrabber() is an XPCOM method which is used by BlueGriffon.
Additionally, it's called internally.  Therefore, we should create a non-virtual
method for this and all internal users should use it.

This patch renames all other related methods to *Internal() for consistency.
Additionally, this fixes a bug of nested calls of ShowGrabber() and
HideGrabber().  This makes CreateGrabber() sets mGrabber directly since
it may be cleared by HideGrabber() while it's running, and also makes
HideGrabber() moves all members who will be cleaned up with local variables
and always clean them up even if it meats an error.

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 9007765 [details]
Bug 1484136 - Create HTMLEditor::RefreshGrabberInternal() for internal use

Makoto Kato [:m_kato] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb28a4b17303
Create HTMLEditor::RefreshGrabberInternal() for internal use r=m_kato

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cb28a4b17303