Closed Bug 1484153 Opened 5 years ago Closed 5 years ago

Unnecessary logging of outerWindowID in listener.js

Categories

(Remote Protocol :: Marionette, enhancement, P1)

Product:
Remote Protocol
Component:
Marionette
Type:
enhancement

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(1 file)

Drop duplicate outerWindowID logging in listener.js.
1.32 KB, patch
whimboo
: review+
Details | Diff | Splinter Review 
When receiving observer notifications during navigation, we log the
outerWindowID:

> logger.debug(`Received observer notification ${topic} for ${winID}`);

This is no longer necessary as
https://bugzilla.mozilla.org/show_bug.cgi?id=1464469 introduced the
outerWindowID as a prefix to all log messages originating from this
frame script.
Assignee: nobody → ato
Status: NEW → ASSIGNED
When receiving observer notifications during navigation, we log the
outerWindowID:

	logger.debug(`Received observer notification ${topic} for ${winID}`);

This is no longer necessary as
https://bugzilla.mozilla.org/show_bug.cgi?id=1464469 introduced the
outerWindowID as a prefix to all log messages originating from this
frame script.
Attachment #9001882 - Flags: review?(hskupin)
Priority: -- → P1
Attachment #9001882 - Flags: review?(hskupin) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f334098ab7bc
Drop duplicate outerWindowID logging in listener.js. r=whimboo
https://hg.mozilla.org/mozilla-central/rev/f334098ab7bc
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.