Closed Bug 1484197 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12547 - [css-properties-values-api] Support string values in StylePropertyMap.set.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12547 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12547
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:
>  [css-properties-values-api] Support string values in StylePropertyMap.set.
>  
>  When producing a CSSStyleValue from a string for a registered custom
>  property, parse the value according to the syntax instead of always
>  creating a CSSUnparsedValue.
>  
>  Note that <color> and <url> are still not supported, because
>  CSSUnsupportedProperty does not work properly for registered custom
>  properties (yet).
>  
>  R=futhark@chromium.org
>  
>  Bug: 641877
>  Change-Id: I806eb5b0c5112956e34457808791367423587c76
>  Reviewed-on: https://chromium-review.googlesource.com/1177755
>  WPT-Export-Revision: 02a11f92d71b6021ade5f76967018c36532c15d9
PR 12547 applied with additional changes from upstream: 218a15f938b8612bac6a74baa8cccdaf53d57221, 5e22f7526ccd18de75184a12dc835cc23d3ea0be, b6f1c190818648dc0c33eb7ada54bf3f209fc938
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests and 42 subtests
FAIL   : 42
ERROR  : 1

New tests that have failures or other problems:
/css/css-properties-values-api/typedom.tentative.html: ERROR
    All computed values correctly reified in comma-separated list: FAIL
    All computed values correctly reified in space-separated list: FAIL
    Computed * is reified as CSSUnparsedValue: FAIL
    Computed <angle> is reified as CSSUnitValue: FAIL
    Computed <color> is reified as CSSStyleValue: FAIL
    Computed <custom-ident> is reified as CSSKeywordValue: FAIL
    Computed <image> [url] is reified as CSSImageValue: FAIL
    Computed <integer> is reified as CSSUnitValue: FAIL
    Computed <length-percentage> [%] is reified as CSSUnitValue: FAIL
    Computed <length-percentage> [px + %] is reified as CSSMathSum: FAIL
    Computed <length-percentage> [px] is reified as CSSUnitValue: FAIL
    Computed <length> is reified as CSSUnitValue: FAIL
    Computed <number> is reified as CSSUnitValue: FAIL
    Computed <percentage> is reified as CSSUnitValue: FAIL
    Computed <resolution> is reified as CSSUnitValue: FAIL
    Computed <time> is reified as CSSUnitValue: FAIL
    Computed <url> is reified as CSSStyleValue: FAIL
    Computed ident is reified as CSSKeywordValue: FAIL
    First computed value correctly reified in comma-separated list: FAIL
    First computed value correctly reified in space-separated list: FAIL
    attributeStyleMap.get returns CSSImageValue for <image>: FAIL
    attributeStyleMap.get returns CSSKeywordValue for <custom-ident>: FAIL
    attributeStyleMap.get returns CSSKeywordValue for thing1 | THING2: FAIL
    attributeStyleMap.get returns CSSMathSum for <length-percentage> [calc(10px + 10%)]: FAIL
    attributeStyleMap.get returns CSSStyleValue for <color>: FAIL
    attributeStyleMap.get returns CSSStyleValue for <url>: FAIL
    attributeStyleMap.get returns CSSUnitValue for <angle>: FAIL
    attributeStyleMap.get returns CSSUnitValue for <integer>: FAIL
    attributeStyleMap.get returns CSSUnitValue for <length-percentage> [10%]: FAIL
    attributeStyleMap.get returns CSSUnitValue for <length-percentage> [10px]: FAIL
    attributeStyleMap.get returns CSSUnitValue for <length>: FAIL
    attributeStyleMap.get returns CSSUnitValue for <length>#: FAIL
    attributeStyleMap.get returns CSSUnitValue for <length>+: FAIL
    attributeStyleMap.get returns CSSUnitValue for <number>: FAIL
    attributeStyleMap.get returns CSSUnitValue for <percentage>: FAIL
    attributeStyleMap.get returns CSSUnitValue for <resolution>: FAIL
    attributeStyleMap.get returns CSSUnitValue for <time>: FAIL
    attributeStyleMap.get returns CSSUnparsedValue for *: FAIL
    attributeStyleMap.get returns CSSUnparsedValue for value with var reference in list: FAIL
    attributeStyleMap.get returns CSSUnparsedValue for value with var references: FAIL
    attributeStyleMap.getAll returns a list of CSSUnitValues for <length>#: FAIL
    attributeStyleMap.getAll returns a list of CSSUnitValues for <length>+: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/52e6db7c7e37
[wpt PR 12547] - [css-properties-values-api] Support string values in StylePropertyMap.set., a=testonly
https://hg.mozilla.org/mozilla-central/rev/52e6db7c7e37
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.