Closed Bug 1484227 Opened Last year Closed Last year

Change improvesearch.noDefaultSearchTile pref to be default true

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 63
Iteration:
63.4 - Aug 20
Tracking Status
firefox62 + verified
firefox63 --- unaffected

People

(Reporter: k88hudson, Assigned: rrosario)

References

(Blocks 1 open bug)

Details

User Story

https://github.com/mozilla/activity-stream/compare/firefox-62b18...firefox-62b19

Attachments

(3 files)

Analysis folks have requested that we change the value of the  improvesearch.noDefaultSearchTile pref to be default true for the 62 release study if possible.
How would you feel about us doing an additional uplift of a line change to set this pref default ON?
Flags: needinfo?(lhenry)
From talking with Kate, sounds like Matt and the analysis team would like this pref (for the first of two experiments, the filtering one) to default to on. We can do that, but I tend to prefer to ship with default off. 

If we ran into any sort of unpredictable problem during startup that caused a crash, for example, we'd be in a difficult situation and might not be able to turn this off for users.  If we trust our pref flipping mechanism then why not ship default off and then set up the experiment by turning it on for whatever % of users?  

From further chatting with Matt and Kate it sounds like that sort of crash is unlikely and the cost of enrolling a large % of users is  high.  This pref was/is on by default in beta without any bad result. 

So, let's go ahead with this for 62 release.
Flags: needinfo?(lhenry)
Assignee: nobody → khudson
Priority: P3 → P1
Assignee: khudson → nobody
Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/cacc2485992147d5330b70760615544303366d76
Fix Bug 1484227 - set improvesearch.noDefaultSearchTile to true

https://github.com/mozilla/activity-stream/commit/e5e63fce7b814591569a405513cc7643fa7e0385
Merge pull request #4352 from mozilla/bug1484227

Fix Bug 1484227 - set improvesearch.noDefaultSearchTile to true
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
MozReview-Commit-ID: 3xTWyJuwnfX
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 9002031 [details]
Bug 1484227 - set improvesearch.noDefaultSearchTile to true

Ed Lee :Mardak (PTO Aug 11-26) has approved the revision.
Attachment #9002031 - Flags: review+
Ok, this should be good to go!
Flags: needinfo?(lhenry)
Comment on attachment 9002031 [details]
Bug 1484227 - set improvesearch.noDefaultSearchTile to true

Approval Request Comment
[Feature/Bug causing the regression]: pref for default filtering search experiment should be default on
[User impact if declined]: shield roll-out is more expensive if this pref is default off
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: just a 1-line pref change
[String changes made/needed]: none
Attachment #9002031 - Flags: approval-mozilla-beta?
OK to uplift for beta 19 as discussed on irc and email with Matt and Kate. This was on by default for beta with no known problems.
Flags: needinfo?(lhenry)
Blocks: 1484328
https://hg.mozilla.org/mozilla-central/rev/b841b6fa93f1
Status: REOPENED → RESOLVED
Iteration: --- → 63.4 - Aug 20
Closed: Last yearLast year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Assignee: nobody → rrosario
Attachment #9002031 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
User Story: (updated)
Depends on: 1482398
I have verified this on Windows 10 x64, Arch Linux and Mac 10.13.3 with the latest version of "Firefox Beta" (63.0b2 - Build ID 20180830123124) installed and I can confirm that the "browser.newtabpage.activity-stream.improvesearch.noDefaultSearchTile" pref is displayed in the "about:config" page, with the "true" value by default. 

However, on Firefox Nightly, the "browser.newtabpage.activity-stream.improvesearch.noDefaultSearchTile" pref was already displayed in the "about:config" page with the "true" value by default, on builds released before logging this report (eg. Build ID - 20180810220115). Considering this I will mark the 63 version as unaffected (please change the flag if my understanding wasn't correct).
Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.