1484249 - A horizontal scroll bar is wrongly displayed in the "Add Search Engine" modal, if the browser is resized

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:
- Firefox 62.0b18 and above

[Affected Platforms]:
- All Windows
- All Linux
- All Mac

[Prerequisites]:
- Have a new Firefox profile.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites and open a new tab.
2. Click the menu button from the top right part of the "Top Sites" area.
3. Select the "Add Search Engine" option and resize the browser until 3 columns of search shortcuts are displayed.
4. Observe the modal.

[Expected result]:
- The "Add Search Engine" elements are correctly displayed and rendered.

**[Actual result]:**
- A horizontal scroll bar is also displayed in the modal's bottom.

**[Notes]:**
- Considering that there is enough space for all the elements to be displayed in the modal, the scroll bar is not needed after the browser is resized.
- Attached a screen recording of the issue:

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4493

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/83671e83aad484d6a03656b9bb5bc8b95d55621b
Fix Bug 1484249 - Remove horizontal scrollbar in modal (#4493)

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/a58d921ba5a1

Comment 4

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the issue is no longer reproducible on the latest Nightly 64.0a1 (Build ID 20181015223336) on Windows 10 x64, Mac 10.13, and Arch Linux x64.