1484306 - Add utility functions to nsFrameList

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

The usage pattern "find the first frame which satisfies a condition, and use it the split frame list" [1] is common in ib-split code. I'll add more while implementing column-span. So I'll add nsFrameList::Split() so that the pattern is easier to use.

[1] https://searchfox.org/mozilla-central/rev/246f2b4fab2c1a6cca99418bc2e4d73d1102cc38/layout/base/nsCSSFrameConstructor.cpp#11237-11239

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1484306 Part 1 - Add nsFrameList::FrameLinkEnumerator::Find().

Use it to implement FindFirstBlock() and FindFirstNonBlock(). This is a
demonstration on how Find() is used. The usage of them will be overhauled in
Part 2 and 3.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1484306 Part 2 - Add nsFrameList::Split(), and use it to replace the usage of FindFirstNonBlock().

This API is similar to Vec::Split() in Rust.
https://doc.rust-lang.org/std/vec/struct.Vec.html#method.split


Depends On D3642

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1484306 Part 3 - Use nsFrameList::Split() to replace the usage of FindFirstBlock().

Depends On D3644

Comment 4

[Daniel Holbert [:dholbert]]

Comment on attachment 9002048 [details]
Bug 1484306 Part 1 - Add nsFrameList::FrameLinkEnumerator::Find().

Daniel Holbert [:dholbert] has approved the revision.

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 9002050 [details]
Bug 1484306 Part 2 - Add nsFrameList::Split(), and use it to replace the usage of FindFirstNonBlock().

Daniel Holbert [:dholbert] has approved the revision.

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 9002051 [details]
Bug 1484306 Part 3 - Use nsFrameList::Split() to replace the usage of FindFirstBlock().

Daniel Holbert [:dholbert] has approved the revision.

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1484306 Part 4 - Use FunctionTypeTraits to yield better error message if aPredicate's signature is wrong.

Depends On D3645

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 9002162 [details]
Bug 1484306 Part 4 - Use FunctionTypeTraits to yield better error message if aPredicate's signature is wrong.

Gerald Squelart [:gerald] has approved the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/82e6a73d8985
Part 1 - Add nsFrameList::FrameLinkEnumerator::Find(). r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b91ab5a0554
Part 2 - Add nsFrameList::Split(), and use it to replace the usage of FindFirstNonBlock(). r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7d40b7574ca
Part 3 - Use nsFrameList::Split() to replace the usage of FindFirstBlock(). r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2814d1bbbd7
Part 4 - Use FunctionTypeTraits to yield better error message if aPredicate's signature is wrong. r=gerald

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/82e6a73d8985
https://hg.mozilla.org/mozilla-central/rev/3b91ab5a0554
https://hg.mozilla.org/mozilla-central/rev/c7d40b7574ca
https://hg.mozilla.org/mozilla-central/rev/b2814d1bbbd7