1484315 - Anti-tracking cookie code has a lot of third-party checks that could be refactored

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect, P3)

Description

[François Marier [:francois]]

I noticed that the cookie code makes a number of third-party checks just before it looks for trackers:

https://searchfox.org/mozilla-central/rev/5dbfd833bbb114afe758db4d4bdbc5b13bcc33ef/netwerk/cookie/CookieServiceChild.cpp#175-191
https://searchfox.org/mozilla-central/rev/5dbfd833bbb114afe758db4d4bdbc5b13bcc33ef/netwerk/cookie/CookieServiceChild.cpp#574-588
https://searchfox.org/mozilla-central/rev/5dbfd833bbb114afe758db4d4bdbc5b13bcc33ef/netwerk/cookie/CookieServiceChild.cpp#630-645
https://searchfox.org/mozilla-central/rev/5dbfd833bbb114afe758db4d4bdbc5b13bcc33ef/netwerk/cookie/CookieServiceParent.cpp#156-169
https://searchfox.org/mozilla-central/rev/5dbfd833bbb114afe758db4d4bdbc5b13bcc33ef/netwerk/cookie/nsCookieService.cpp#2038-2053
https://searchfox.org/mozilla-central/rev/5dbfd833bbb114afe758db4d4bdbc5b13bcc33ef/netwerk/cookie/nsCookieService.cpp#2145-2160

In bug 1482950, I'm introducing a GetIsThirdPartyTrackingResource() function which does the correct third-party check (not trivial, see bug 1108017). It might be worth moving the cookie code over to that.

Comment 1

[(no longer active)]

Yes, it would be nice to use the same code here too...

Comment 2

[(no longer active)]

Attachment: Bug 1484315 - Refactor the third-party checks used in the cookie backend;

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbb1fd48d429
Refactor the third-party checks used in the cookie backend; r=baku

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/cbb1fd48d429