1484374 - GeckoView is not handling the autoplay-media permission request.

Status: RESOLVED FIXED

(GeckoView :: Media, defect)

Description

[Randall Barker [:rbarker]]

When a page has an auto playing media element, GeckoView throws the following exception. It needs to handle this new permission.

08-17 15:53:14.796  2466  2466 E GeckoCrashHandler: >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
08-17 15:53:14.796  2466  2466 E GeckoCrashHandler: java.lang.IllegalArgumentException: Unknown permission request: autoplay-media
08-17 15:53:14.796  2466  2466 E GeckoCrashHandler:     at org.mozilla.geckoview.GeckoSession$6.handleMessage(GeckoSession.java:493)
08-17 15:53:14.796  2466  2466 E GeckoCrashHandler:     at org.mozilla.geckoview.GeckoSession$6.handleMessage(GeckoSession.java:470)
08-17 15:53:14.796  2466  2466 E GeckoCrashHandler:     at org.mozilla.geckoview.GeckoSessionHandler.handleMessage(GeckoSessionHandler.java:79)
08-17 15:53:14.796  2466  2466 E GeckoCrashHandler:     at org.mozilla.gecko.EventDispatcher$2.run(EventDispatcher.java:344)
08-17 15:53:14.796  2466  2466 E GeckoCrashHandler:     at android.os.Handler.handleCallback(Handler.java:751)
08-17 15:53:14.796  2466  2466 E GeckoCrashHandler:     at android.os.Handler.dispatchMessage(Handler.java:95)
08-17 15:53:14.796  2466  2466 E GeckoCrashHandler:     at android.os.Looper.loop(Looper.java:154)
08-17 15:53:14.796  2466  2466 E GeckoCrashHandler:     at android.app.ActivityThread.main(ActivityThread.java:6121)
08-17 15:53:14.796  2466  2466 E GeckoCrashHandler:     at java.lang.reflect.Method.invoke(Native Method)
08-17 15:53:14.796  2466  2466 E GeckoCrashHandler:     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
08-17 15:53:14.796  2466  2466 E GeckoCrashHandler:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)
08-17 15:53:14.796  2466  2466 E GeckoCrashHandler: Main thread (71) stack:
08-17 15:53:14.797  2466  2466 E GeckoCrashHandler:     org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
08-17 15:53:14.797  2466  2466 E GeckoCrashHandler:     org.mozilla.gecko.GeckoThread.run(GeckoThread.java:504)

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Would it make sense to gracefully handle unknown permissions, or is it smart for now to block, fatally crash, on unknown permissions?

Comment 2

[Randall Barker [:rbarker]]

Attachment: Bug 1484374 - Update GeckoView to handle the autoplay-media permission request. r=snorp

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 9002152 [details]
Bug 1484374 - Update GeckoView to handle the autoplay-media permission request. r=snorp

James Willcox (:snorp) ([e-mail]) has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/369762aaed07
Update GeckoView to handle the autoplay-media permission request. r=snorp

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/369762aaed07

Comment 6

[Chris Peterson [:cpeterson]]

status-firefox62=wontfix because we don't need to uplift to GV 62 Beta

Comment 7

[Chris Peterson [:cpeterson]]

Moving some media bugs to the new GeckoView::Media component.