148444 - Bad pref file references in embedding configurations

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Embedding: Mac, defect)

Description

[Brian Nesse (gone)]

This is not mac specific, but none of the other categories make sense, and the
mac is somewhat more affected than the other platforms, so I'm defaulting this
to Embedding:Mac.

While building Chimera, I've noticed warnings/errors during the make process
referencing initpref.js & unix.js. Initpref.js no longer exists and is invalid
on all platforms, and for the mach-o and cocoa builds I think we should be
referencing macprefs.js and macxprefs.js instead of unix.js.

Comment 1

[Alec Flett]

is this a Makefile.in-related thing? (I've never build chimera before)
cc'ing seawood

Comment 2

[Brian Nesse (gone)]

The specific files are basebrowser-<insert_your_platform_here> and the cocoa
embed project builder file.

http://lxr.mozilla.org/seamonkey/search?string=initpref.js

Comment 3

[hacker formerly known as [e-mail]]

The warnings are harmless.   Since the files aren't capable of ifdefs, they list
files that aren't be needed for specific configurations.  Wrt the mac prefs
files, I was under the impression that the mach-o build used the unix prefs like
it does the unix fileio.  Cc'ing Adam Lock.

Comment 4

[Brian Nesse (gone)]

Sure, I realize the warnings are harmless... But it's not a configuration
thing... InitPrefs.js is not valid on *any* platform... the file no longer
exists. I'm just saying the script(s) should be changed to reflect that.

As for the macprefs thing... These are application level prefs. As this is a Mac
build I think the Mac prefs are appropriate. The mach-o Mozilla build is
currently using the mac files... if this is wrong for some reason, we need to
change that too.

Comment 5

[Mike Pinkerton (not reading bugmail)]

it's a mac app, we want to use mac prefs

Comment 6

[Brian Nesse (gone)]

Attachment: Proposed patch

This is what I believe the various configurations (and the cocoa embed project)
should look like.

Comment 7

[Adam Lock]

Comment on attachment 86088 [details] [diff] [review]
Proposed patch

r=adamlock on the non-Macho manifest changes. Mike do you want to r= those?

Comment 8

[Mike Pinkerton (not reading bugmail)]

r=pink on the mach-o stuff and pb changes

Comment 9

[Alec Flett]

I want seawood to r/sr this....

Comment 10

[hacker formerly known as [e-mail]]

Comment on attachment 86088 [details] [diff] [review]
Proposed patch

r/sr=cls

Comment 11

[Brian Nesse (gone)]

Fix checked in.

Comment 12

[Michael Dunn]

To Dharma for verification

Comment 13

[dsirnapalli]

patch checked into corresponding files. verified it on latest trunk build.
Marking the bug verified.

Comment 14

[dsirnapalli]

The patch says that initpref.js is no longer valid. I verified it on branch
build(2002-10-09-05-1.0) for PPEmbed and MFCEmbed. Both of them still contains
initpref.js.
However the trunk builds donot have that. Should it be removed from branch.

Comment 15

[Benjamin Smedberg]

Mass change of bugs in the Embedding: Mac component in preparation for archiving it. I don't believe any of these are useful any more, as we don't have a mac embedding API. If they are relevant, they should be moved to an alternate component.