1484472 - Avoid FileUriExposed exceptions in ExternalIntentDuringPrivateBrowsingPromptFragment

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Jan Henning [:JanH]]

I'm not sure under what circumstances exactly those happen, since the comment in that file claims that is intended for the handling of Intent:// URIs only, but apparently we've ended up routing some file:// URIs for downloaded files that way as well. Following the precedent from bug 1450449, we should temporarily disable strict mode to avoid a crash.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1484472 - Avoid FileUriExposedException in ExternalIntentDuringPrivateBrowsingPromptFragment. r?jchen

The fragment is also used to handle intents launched through GeckoAppShell.
openUriExternal(), such as e.g. when launching downloaded files from
about:downloads.

The synchronous code path when not in private browsing is already covered by the
code added in bug 1450449, but the async path through the fragment when in
private browsing needs to be handled separately.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9002904 [details]
Bug 1484472 - Avoid FileUriExposedException in ExternalIntentDuringPrivateBrowsingPromptFragment. r?jchen

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4dbf6f8f9990
Avoid FileUriExposedException in ExternalIntentDuringPrivateBrowsingPromptFragment. r=jchen

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4dbf6f8f9990