Closed Bug 1484472 Opened 6 years ago Closed 6 years ago

Avoid FileUriExposed exceptions in ExternalIntentDuringPrivateBrowsingPromptFragment

Categories

(Firefox for Android Graveyard :: General, enhancement)

Firefox 63
All
Android
enhancement
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: JanH, Assigned: JanH)

References

Details

Attachments

(1 file)

I'm not sure under what circumstances exactly those happen, since the comment in that file claims that is intended for the handling of Intent:// URIs only, but apparently we've ended up routing some file:// URIs for downloaded files that way as well. Following the precedent from bug 1450449, we should temporarily disable strict mode to avoid a crash.
The fragment is also used to handle intents launched through GeckoAppShell. openUriExternal(), such as e.g. when launching downloaded files from about:downloads. The synchronous code path when not in private browsing is already covered by the code added in bug 1450449, but the async path through the fragment when in private browsing needs to be handled separately.
Comment on attachment 9002904 [details] Bug 1484472 - Avoid FileUriExposedException in ExternalIntentDuringPrivateBrowsingPromptFragment. r?jchen Jim Chen [:jchen] [:darchons] has approved the revision.
Attachment #9002904 - Flags: review+
Pushed by mozilla@buttercookie.de: https://hg.mozilla.org/integration/autoland/rev/4dbf6f8f9990 Avoid FileUriExposedException in ExternalIntentDuringPrivateBrowsingPromptFragment. r=jchen
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: