Closed Bug 1484517 Opened 2 years ago Closed 2 years ago

Intermittent testing\firefox-ui\tests\functional\safebrowsing\test_warning_pages.py TestSafeBrowsingWarningPages.test_warning_pages | AttributeError: 'NoneType' object has no attribute 'click'

Categories

(Testing :: Firefox UI Tests, defect, P5)

Version 3
defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1482029

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [retriggered])

Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=194748404&repo=autoland

https://queue.taskcluster.net/v1/task/Og9k8v6MTWiU3lsJ5jrhXg/runs/0/artifacts/public/logs/live_backing.log

11:13:13     INFO -  ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
11:13:13     INFO -  [Parent 7316, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
11:13:13     INFO -  [Parent 7316, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
11:13:14     INFO -  1534677194482	Marionette	DEBUG	Received observer notification xpcom-will-shutdown
11:13:14     INFO -  1534677194482	Marionette	INFO	Stopped listening on port 2828
11:13:14     INFO -  1534677194482	Marionette	DEBUG	Remote service is inactive
11:13:15  WARNING - Failed to gather test failure debug: Process has been unexpectedly closed (Exit code: 0) (Reason: No data received over socket)
11:13:15     INFO - TEST-UNEXPECTED-ERROR | testing\firefox-ui\tests\functional\safebrowsing\test_warning_pages.py TestSafeBrowsingWarningPages.test_warning_pages | AttributeError: 'NoneType' object has no attribute 'click'
11:13:15     INFO - Traceback (most recent call last):
11:13:15     INFO -   File "Z:\task_1534676832\build\venv\lib\site-packages\marionette_harness\marionette_test\testcases.py", line 159, in run
11:13:15     INFO -     testMethod()
11:13:15     INFO -   File "Z:\task_1534676832\build\tests\firefox-ui\tests\testing\firefox-ui\tests\functional\safebrowsing\test_warning_pages.py", line 63, in test_warning_pages
11:13:15     INFO -     self.check_report_link(unsafe_page)
11:13:15     INFO -   File "Z:\task_1534676832\build\tests\firefox-ui\tests\testing\firefox-ui\tests\functional\safebrowsing\test_warning_pages.py", line 90, in check_report_link
11:13:15     INFO -     link.click()
11:13:15     INFO - TEST-INFO took 22102ms
11:13:15    ERROR - test_end for testing\firefox-ui\tests\functional\safebrowsing\test_warning_pages.py TestSafeBrowsingWarningPages.test_warning_pages logged while not in progress. Logged with data: {"status": "ERROR", "extra": {"class_name": "test_warning_pages.TestSafeBrowsingWarningPages", "method_name": "test_warning_pages"}, "expected": "PASS", "test": "testing\\firefox-ui\\tests\\functional\\safebrowsing\\test_warning_pages.py TestSafeBrowsingWarningPages.test_warning_pages", "message": "MarionetteException: Please start a session", "stack": "Traceback (most recent call last):\n  File \"Z:\\task_1534676832\\build\\venv\\lib\\site-packages\\marionette_harness\\marionette_test\\testcases.py\", line 190, in run\n    self.tearDown()\n  File \"Z:\\task_1534676832\\build\\tests\\firefox-ui\\tests\\testing\\firefox-ui\\tests\\functional\\safebrowsing\\test_warning_pages.py\", line 48, in tearDown\n    super(TestSafeBrowsingWarningPages, self).tearDown()\n  File \"Z:\\task_1534676832\\build\\venv\\lib\\site-packages\\firefox_puppeteer\\mixins.py\", line 97, in tearDown\n    self.marionette.set_context('chrome')\n  File \"Z:\\task_1534676832\\build\\venv\\lib\\site-packages\\marionette_driver\\marionette.py\", line 1426, in set_context\n    {\"value\": context})\n  File \"Z:\\task_1534676832\\build\\venv\\lib\\site-packages\\marionette_driver\\decorators.py\", line 26, in _\n    return func(*args, **kwargs)\n  File \"Z:\\task_1534676832\\build\\venv\\lib\\site-packages\\marionette_driver\\marionette.py\", line 745, in _send_message\n    raise errors.MarionetteException(\"Please start a session\")\n"}
There as a pipe error and Firefox just closed:

> 11:13:14     INFO -  1534677194482	Marionette	DEBUG	Received observer notification xpcom-will-shutdown
> 11:13:14     INFO -  1534677194482	Marionette	INFO	Stopped listening on port 2828
> 11:13:14     INFO -  1534677194482	Marionette	DEBUG	Remote service is inactive
> 11:13:15  WARNING - Failed to gather test failure debug: Process has been unexpectedly closed (Exit code: 0) (Reason: No data received over socket)
I agree it isn't very clear, there is a lot of data here.  I don't see bug 1482029 in the url linked above, I see what looks to be an increase in failures on Bug 1484461, but that could easily be misleading.  I suspect we just need the test author to work on fixing this test.
Flags: needinfo?(jmaher)
So I'm fairly sure that any of the classified failures as shown by Orange Factor for this bug are wrong! They are all related to bug 1482029. Not sure why everyone classifies the assertion against this bug, especially when the bug summary is not visible in the failure summer on Treeherder at all. This bug is not a catch all.

Sebastian, can you please make sure that this false classification stops? Thanks.
Flags: needinfo?(aryx.bugmail)
Flags: needinfo?(aryx.bugmail)
(In reply to Henrik Skupin (:whimboo) from comment #6)
> So I'm fairly sure that any of the classified failures as shown by Orange
> Factor for this bug are wrong! They are all related to bug 1482029. Not sure
> why everyone classifies the assertion against this bug, especially when the
> bug summary is not visible in the failure summer on Treeherder at all. This
> bug is not a catch all.
> 
> Sebastian, can you please make sure that this false classification stops?
> Thanks.

Hi. When a test fails on 2 or more files (has 2 or more failure lines that seem unrelated) we usually classify it with all the bugs suggested. Again, if they are not related, meaning the failure is not on the same file.

I guess that's what we did here too. Ayrx explained the difference here and we'll try as much as possible not to missclassify any other bugs. 

We apologize for the confusion regarding this failure.
(In reply to Andreea Pavel [:apavel] from comment #7)
> Hi. When a test fails on 2 or more files (has 2 or more failure lines that
> seem unrelated) we usually classify it with all the bugs suggested. Again,
> if they are not related, meaning the failure is not on the same file.

That's not what happened in most of the cases. See for example https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e4e2245fc1428c33db179ca2f242b922ad988d79&selectedJob=196015814. Only this bug has been classified.

Also note that the assertion right before was raised nearly at the same time, which means that it has a side-effect on the test.

So as long as we keep classifying the real underlying problem to raise it's priority through OF I'm fine. 

I will mark the dependency to bug 1482029 now.
Depends on: 1482029
Flags: needinfo?(apavel)
(In reply to Henrik Skupin (:whimboo) from comment #9)
> (In reply to Andreea Pavel [:apavel] from comment #7)
> > Hi. When a test fails on 2 or more files (has 2 or more failure lines that
> > seem unrelated) we usually classify it with all the bugs suggested. Again,
> > if they are not related, meaning the failure is not on the same file.
> 
> That's not what happened in most of the cases. See for example
> https://treeherder.mozilla.org/#/
> jobs?repo=autoland&revision=e4e2245fc1428c33db179ca2f242b922ad988d79&selected
> Job=196015814. Only this bug has been classified.
> 
> Also note that the assertion right before was raised nearly at the same
> time, which means that it has a side-effect on the test.
> 
> So as long as we keep classifying the real underlying problem to raise it's
> priority through OF I'm fine. 
> 
> I will mark the dependency to bug 1482029 now.

The example you gave me, is one classified by Aryx, which can be a correction from when he looked over what we did.
Flags: needinfo?(apavel) → needinfo?(aryx.bugmail)
Flags: needinfo?(aryx.bugmail)
No more failures since bug 1482029 was fixed.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1482029
You need to log in before you can comment on or make changes to this bug.