1484521 - Misplaced list markers with text-align:justify

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[dolphinling]

Attachment: Testcase

63.0a1 (2018-08-18) (64-bit), linux

When a ul or ol (or its container) has text-align: justify, the list markers are misplaced. This is a regression, it does not occur in 61.0.2

First noticed using the Brief addon to read RSS feeds.

Comment 1

[dolphinling]

Narrowed the regression range to between the 2018-08-12-22 and 2018-08-13-10 nightlies.

Comment 2

[dolphinling]

Best guess: regression from bug 1478178

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

[Tracking Requested - why for this release]:  This is a layout regression that I'd prefer not to ship.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1484521 - Prepend bullet frame in line layout. r=dholbert

Bug 1478178 regressed this case because bullet frame is the last frame
added to line layout, rather than the first, so when we try to apply
justification, we end up giving it the accumulated offset of the whole
line.

Bullet frame has to be added after other frames in the line has been
placed, because its ppresence may depend on whether the line is empty.
However, bullet frame is logically the first element in a line and
appending it to the end is somehow counter-intuitive.

Thus, this patch fixes the issue via prepending bullet frame in line
layout, so that the order of frames there can be a bit more reliable.

Comment 5

[Michal Čaplygin [:myf]]

Attachment: 1484521-testcase.html

Affects `text-align: right` as well, quite predictably.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

I think the behavior of `text-align: right` is intentional, or at least not a recent regression. If you think that behavior is wrong, it's probably better file a new bug for it.

Comment 7

[Michal Čaplygin [:myf]]

You are right; turns out it is in fact bug 25291 from 2000.  Sorry, my bad.

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for 63 as it's a recent regression.

Comment 10

[Jonathan Kew [:jfkthame]]

Comment on attachment 9002373 [details]
Bug 1484521 - Prepend bullet frame in line layout. r=dholbert

Jonathan Kew (:jfkthame) has approved the revision.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c420838bf52
Prepend bullet frame in line layout. r=jfkthame

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5c420838bf52