Closed Bug 1484541 Opened 7 years ago Closed 7 years ago

media/libcubeb/gtest/test_duplex.cpp:45: bad test ?

Categories

(Core :: Audio/Video: cubeb, defect, P3)

Product:
Core
Component:
Audio/Video: cubeb
Version:
61 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox61 --- affected

People

(Reporter: dcb314, Assigned: achronop)

References

Details

(Whiteboard: [need info achronop 2018-08-31])

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0 Build ID: 20180809102347 Steps to reproduce: [trunk/media/libcubeb/gtest/test_duplex.cpp:45]: (warning) Logical conjunction always evaluates to false: EXPR <= -1.0 && EXPR >= 1.0. > [trunk/media/libcubeb/gtest/test_record.cpp:40]: (warning) Logical conjunction always evaluates to false: EXPR <= -1.0 && EXPR >= 1.0. Actual results: Source code for the first one is if (ib[i] <= -1.0 && ib[i] >= 1.0) { Maybe better code if (ib[i] <= -1.0 || ib[i] >= 1.0) { Second one is a duplicate.
status-firefox61: --- → affected
Component: Untriaged → Audio/Video: cubeb
Product: Firefox → Core
Alex, what do you think about this?
Flags: needinfo?(achronop)
Whiteboard: [need info achronop 2018-08-31]
This is a valid issue, nice catch!
Assignee: nobody → achronop
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(achronop)
Priority: -- → P3
This is under review in cubeb repo: https://github.com/kinetiknz/cubeb/pull/461
Depends on: 1500377
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.