Closed Bug 1484585 Opened 2 years ago Closed 2 years ago

Update UI tour copy for identity popup changes in 63

Categories

(www.mozilla.org :: Pages & Content, enhancement, P2)

Production
enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mheubusch, Assigned: agibson)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1466235 +++

In bug 1462470 we're changing the UI in the identity popup and need to update our UI tour copy as well. 

This bug is just for the web-hosted strings for the Content Blocking UI Tour

For Version 1, Step 2:

Differences to expect
Content blocking can keep parts of pages or entire pages from loading. [Next]


For Version 1, Step 3:
Turn off blocking for trusted sites
If content blocking prevents you from using a site you trust, you can select Disable For This Site in this site information panel. [OK, Got It]

Thanks for learning about Content Blocking. (link: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/content-blocking)

For Version 2, Step 2:
Differences to expect
You can adjust your settings to block all trackers or just those that slow down your browsing. [Next]

For Version 2, Step 3:
Turn off blocking for trusted sites
If content blocking prevents you from using a site you trust, you can select Disable For This Site in this site information panel. [OK, Got It]
Thanks for learning about Content Blocking. (link: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/content-blocking)
Tony - please indicate when these updates need to land.  I believe Sept 10th was mentioned but want to confirm.

Since the next update will be on the 5th, I want to be sure it is understood that it will take time (typically 2-3) weeks for localization of the new strings to catch up.
Flags: needinfo?(tcinotto)
(In reply to Eric Renaud [:erenaud] from comment #1)
> Tony - please indicate when these updates need to land.  I believe Sept 10th
> was mentioned but want to confirm.
> 
> Since the next update will be on the 5th, I want to be sure it is understood
> that it will take time (typically 2-3) weeks for localization of the new
> strings to catch up.

We will conduct a Shield Study that will require these updates to be landed on September 10th. So it sounds like we have the risk that we would have almost a week to two weeks with no localization done for the onboarding, correct? @michelle do you think that's an acceptable risk?
Flags: needinfo?(tcinotto) → needinfo?(mheubusch)
I am ok with the risk.  

Also, here is the document with the variations on the tour: https://docs.google.com/presentation/d/1_9hORyPf7PoiOURhMbGCdR7A_R_Ip6tYWYMtlZaiTGE/edit?usp=sharing
Flags: needinfo?(mheubusch)
This changes requested are now up on demo server for review. To test please follow the following instructions:


1. Whitelist UITour for the demo by creating a new preference called browser.uitour.testingOrigins in about:config and assign it a value of https://bedrock-demo-agibson.oregon-b.moz.works/.

2. The visit the following URLs:

- https://bedrock-demo-agibson.oregon-b.moz.works/en-US/firefox/63.0/tracking-protection/start/?newtab=true&variation=1
- https://bedrock-demo-agibson.oregon-b.moz.works/en-US/firefox/63.0/tracking-protection/start/?newtab=true&variation=2

Some notes:

- This new tour will show for en-US only. I can't find any clear l10n requirements, but I'm assuming this is correct as this is a Shield study. Please clarify if these new strings should be translated, or not.

- This new tour will only be shown if ?newtab=true, which implies there will no longer be a tour in PB mode via "See how it works". If this is incorrect, please clarify what should happen.

- We're currently missing strings for if the users clicks "Disable For This Site" mid-tour.

Michelle, if you could please QA and answer any questions that would be appreciated. Thanks
Flags: needinfo?(mheubusch)
Ok, we had a Vidyo meeting to discuss my open questions, which should hopefully now all be resolved.

Updated demo links and testing instructions:

First, to avoid confusion make sure to test in FF 63 Beta (strings in Control Center are different to what's in Nightly).

Next, whitelist UITour for the demo instance by creating a new preference called `browser.uitour.testingOrigins` in `about:config` and assign it a value of `https://bedrock-demo-agibson.oregon-b.moz.works/`.

Then you should be able to test for following URLs (if you don't see an info panel open on step 1, whitelisting did not work so try again):

Private Browsing mode (make sure to test in a new PB window):

https://bedrock-demo-agibson.oregon-b.moz.works/en-US/firefox/63.0/tracking-protection/start/?variation=1
https://bedrock-demo-agibson.oregon-b.moz.works/en-US/firefox/63.0/tracking-protection/start/?variation=2

Normal mode (make sure to test in a non PB window)

https://bedrock-demo-agibson.oregon-b.moz.works/en-US/firefox/63.0/tracking-protection/start/?variation=1&newtab=true
https://bedrock-demo-agibson.oregon-b.moz.works/en-US/firefox/63.0/tracking-protection/start/?variation=2&newtab=true
Attached file GitHub pull request
Thanks, Alex.  

I missed a few things. 

https://bedrock-demo-agibson.oregon-b.moz.works/en-US/firefox/63.0/tracking-protection/start/?variation=0&step=3 and state where TP is enabled
Change "Disable Blocking For This Site" to "Disable Blocking Temporarily" (also updated slide 15

https://bedrock-demo-agibson.oregon-b.moz.works/en-US/firefox/63.0/tracking-protection/start/?variation=0&step=3 and state where TP is disabled
Change "Enable protection." to "Enable Blocking For This Site." (Also updated slide 15). 

https://bedrock-demo-agibson.oregon-b.moz.works/en-US/firefox/63.0/tracking-protection/start/?variation=0&newtab=true&step=3 and state where TP is disabled
Change "Enable protection." to "Enable Blocking For This Site." (Also updated slide 12).
Flags: needinfo?(mheubusch)
Updated thank you - please test agin.
Flags: needinfo?(mheubusch)
Thanks, Alex. All versions look great.  Tanvi, Tony, I've done a full content review - what are next steps for QA?
Flags: needinfo?(tcinotto)
Flags: needinfo?(tanvi)
Ok great - I'll relay my question from Slack here for posterity:

--- 

One last question I have is regard to l10n. I understand the shield study in 63 Beta will be en-US only, but you would like to start translating these new strings ahead of time, is that correct?

If that’s correct, I would propose we do the following:
1. Only show these new tour variations to en locales (all other locales will get current TP strings)
2. While 63 is in Beta, start translating the new strings.
3. When ready, file a new bug for us to remove the ‘en’ conditional so that all locales can get the new content blocking variations.
Does that sound workable to you?

We need to give enough time for l10n to happen before we flip on for everybody (edited)
It usually takes at least 2-3 weeks, but Flod & Peiying can confirm
(In reply to Alex Gibson [:agibson] from comment #11)
> Ok great - I'll relay my question from Slack here for posterity:
> 
> --- 
> 
> One last question I have is regard to l10n. I understand the shield study in
> 63 Beta will be en-US only, but you would like to start translating these
> new strings ahead of time, is that correct?
> 
> If that’s correct, I would propose we do the following:
> 1. Only show these new tour variations to en locales (all other locales will
> get current TP strings)
> 2. While 63 is in Beta, start translating the new strings.
> 3. When ready, file a new bug for us to remove the ‘en’ conditional so that
> all locales can get the new content blocking variations.
> Does that sound workable to you?
Sounds good. "When ready" means when we have enough locales localized (80%+) or when 63 goes to production?
> 
> We need to give enough time for l10n to happen before we flip on for
> everybody (edited)
> It usually takes at least 2-3 weeks, but Flod & Peiying can confirm

Usually it is the case but more time is better because there are lots of competing projects, especially with key locales.
> Sounds good. "When ready" means when we have enough locales localized (80%+) or when 63 goes to production?

I would assume when we have enough locales translated (showing english strings to non-english languages would be bad), but I'll defer to Tanvi and Tony here.
At some point in Firefox 63 beta (probably early October, but I'm not the one who decides that), Content Blocking will be enabled by default.  Then we'd need the string in all locales.  So changing all the strings for en for now would be great, and having the rest ready in early October would be fine.

Thanks!
Flags: needinfo?(tanvi)
Thanks Alex! As Michelle mentioned is there a QA process that we typically follow for onboarding screens like this? Do these get tested by soft vision, including the end to end experience?
Flags: needinfo?(agibson)
As far as the mozorg team goes, this has been code reviewed and tested to the best of our ability. If you would like additional QA on the Firefox side of things, you'll need to arrange this with whomever usually QA's these types of product changes. I do know soft vision have done this type of thing in the past.
Flags: needinfo?(agibson)
I brought this up in anti-tracking channel but there was no conclusion. 

I'm wondering if we can QA this as part of Fastblock Shield Study QA since we have a little more time. We're trying to aim to get cookie restrictions out today and I don't think we want to block that with additional QA.
Flags: needinfo?(tcinotto)
Flags: needinfo?(mheubusch)
Two small fixes I found - 

in Variation 1, step 3 with blocking disabled, please change "Control Center panel" to "this panel" for consistency with other variations. 

in Variation 0, private mode, step done, please capitalize the T on the button that says Restart Tour
Flags: needinfo?(agibson)
(In reply to mheubusch from comment #20)
> Two small fixes I found - 
> 
> in Variation 1, step 3 with blocking disabled, please change "Control Center
> panel" to "this panel" for consistency with other variations. 
> 
> in Variation 0, private mode, step done, please capitalize the T on the
> button that says Restart Tour

I can capitalize the T in "Restart tour"  as this is a string we already have in the template, but we're frozen for other string changes now, so the first fix we may have to live with.
Flags: needinfo?(agibson)
Attached file GitHub Pull Request
PR to change "Restart tour" to "Restart Tour"
Assignee: nobody → agibson
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.