Occur the 'NS_ERROR_NOT_INITIALIZED' when switching the window to bottom dock.

RESOLVED FIXED in Firefox 63

Status

defect
RESOLVED FIXED
Last year
Last year

People

(Reporter: mantaroh, Assigned: mantaroh)

Tracking

(Blocks 1 bug)

unspecified
Firefox 63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

STR:
 1. Separate the devtools to window mode.
 2. Dock the devtools to bottom mode.

AR:
 NS_ERROR_NOT_INITIALIZED is occurred in MenuButton.js:191.

We should remove the event listener('hidden' event) before destroying the HTMLTooltip since we issue the window.setTimeout() in this event listener. I think that this event listener is no longer to observe this event after destroying the HTMLTooltip.

------------------
Log:
[Exception... "Component not initialized"  nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame :: resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/components/menu/MenuButton.js :: onHidden :: line 191"  data: no]: onHidden@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/components/menu/MenuButton.js:191:5
emit@resource://devtools/shared/base-loader.js -> resource://devtools/shared/event-emitter.js:178:15
emit@resource://devtools/shared/base-loader.js -> resource://devtools/shared/event-emitter.js:255:5
hide@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/widgets/tooltip/HTMLTooltip.js:702:7
async*destroy@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/widgets/tooltip/HTMLTooltip.js:746:5
resetTooltip@resource://devtools/shared/base-loader.js -> resource://devtools/client/shared/components/menu/MenuButton.js:129:5
MenuButton will listen the HTMLTooltip hidden event even if HTMLTooltip is
destroyed. As a result of it, the timer which issued in the MenuButton's event
listener might fail due to the target window is destroyed. (e.g., switching the
dock mode to bottom  from window mode.)

This patch will remove this event listener before destroying the HTMLTooltip.
Assignee: nobody → mantaroh
Status: NEW → ASSIGNED
Comment on attachment 9002370 [details]
Bug 1484595 - Remove the HTMLTooltip hidden event listener before destroying the HTMLTooltip. r?birtles

Brian Birtles (:birtles) has approved the revision.
Attachment #9002370 - Flags: review+
Pushed by mantaroh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fc5c57e9b65b
Remove the HTMLTooltip hidden event listener before destroying the HTMLTooltip. r=birtles
Backed out changeset fc5c57e9b65b (Bug 1484595) for linting failure on a CLOSED TREE

Problematic push: https://hg.mozilla.org/integration/autoland/rev/fc5c57e9b65b65e98fdc8e792913a5553bb67897
Failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=194800965
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=194800965&repo=autoland&lineNumber=418

[vcs 2018-08-20T07:32:34.517Z] PERFHERDER_DATA: {"framework": {"name": "vcs"}, "suites": [{"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "clone_errored", "shouldAlert": false, "subtests": [], "value": 1489.4726150035858}, {"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "overall", "shouldAlert": false, "subtests": [], "value": 1490.109344959259}]}
[vcs 2018-08-20T07:32:34.517Z] abort: unexpected response from remote server: empty string
[taskcluster 2018-08-20 07:32:34.913Z] === Task Finished ===
[taskcluster 2018-08-20 07:32:34.914Z] Unsuccessful task run with exit code: 255 completed in 1529.35 seconds
Flags: needinfo?(mantaroh)
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41993cf46d6a
Backed out changeset fc5c57e9b65b for linting failure on a CLOSED TREE
Pushed by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c023d39fa5a
Remove the HTMLTooltip hidden event listener before destroying the HTMLTooltip. r=birtles
https://hg.mozilla.org/mozilla-central/rev/2c023d39fa5a
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Flags: needinfo?(mantaroh)
You need to log in before you can comment on or make changes to this bug.