1484640 - Enable ESLint for mobile/android/chrome/content/browser.js

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Mark Banner (:standard8)]

This used to be ignored because it used non-standard try/catch forms. However, these have been removed now, so we should be able to enable ESLint on this file.

The reference will need to be removed from <topsrcdir>/.eslintignore

Comment 1

[Shivam Singhal [ :championshuttler ]]

Hi Mark , Can I take this up?

Thanks

Comment 2

[Mark Banner (:standard8)]

(In reply to Shivam Singhal [ :championshuttler ] from comment #1)

Hi Mark , Can I take this up?

Sure, but don't forget the other bugs you're assigned to as well...

Comment 3

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1484640 - Enable ESLint for mobile/android/chrome/content/browser.js (Automatic Changes). r=standard8

Comment 4

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1484640 - Enable ESLint for mobile/android/chrome/content/browser.js (Manual Changes). r=standard8

Depends on D22890

Comment 5

[Mark Banner (:standard8)]

This failed to land:

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmp23IH2N\npatching file mobile/android/chrome/content/browser.js\nHunk #25 FAILED at 1319\n1 out of 162 hunks FAILED -- saving rejects to file mobile/android/chrome/content/browser.js.rej\nabort: patch failed to apply', '')

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5914426902ac
Enable ESLint for mobile/android/chrome/content/browser.js (Automatic Changes). r=snorp
https://hg.mozilla.org/integration/autoland/rev/54f421232d08
Enable ESLint for mobile/android/chrome/content/browser.js (Manual Changes). r=snorp

Comment 7

[Cristian Brindusan [:cbrindusan]]

Backed out 2 changesets (Bug 1484640) for ESlint failure at browser.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/e91f6d3bc047478cdd53a12ea2b5b02b6856d849

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&selectedJob=235039882&revision=54f421232d08b49c1bd3769e680f3c61e163f72e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=235039882&repo=autoland&lineNumber=294

Comment 8

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1484640 - Enable ESLint for mobile/android/chrome/content/browser.js (Automatic Changes). r=snorp,standard8

Comment 9

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1484640 - Enable ESLint for mobile/android/chrome/content/browser.js (Manual Changes). r=standard8,snorp

Depends on D24318

Comment 10

[Shivam Singhal [ :championshuttler ]]

@Standard8 Sorry for that , made changes and made new revisions

Thanks

Comment 11

[Mark Banner (:standard8)]

Could you try pushing the changes to the existing commits? That would make it easier.

You should just be able to edit the commit messages of both commits, and change the differential revision to point at the old Dnnnn numbers, then push again (you can un-abandon revisions).

Comment 12

[Shivam Singhal [ :championshuttler ]]

@Standard8 Made the changes. Thanks

Comment 13

[Andreea Pavel [:apavel]]

What exactly needs to land here?

Lando is blocked: https://irccloud.mozilla.com/file/PUOG6kdJ/lando.jpg

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:championshuttler, could you have a look please?

Comment 15

[Mark Banner (:standard8)]

I've rebased the patches and fix the bitrot as I'm not sure Shivam is active at the moment. I'll push this to try, then hopefully push to autoland.

Comment 16

[Shivam Singhal [ :championshuttler ]]

Hi Mark,

Thanks for doing this,I did not know the reason why lando raised this error really. I am not active for some, have university exams :(

Thanks

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ad266f5412e
Enable ESLint for mobile/android/chrome/content/browser.js (Automatic Changes). r=snorp
https://hg.mozilla.org/integration/autoland/rev/8f826767d3d6
Enable ESLint for mobile/android/chrome/content/browser.js (Manual Changes). r=snorp

Comment 18

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4ad266f5412e
https://hg.mozilla.org/mozilla-central/rev/8f826767d3d6