Enable ESLint for mobile/android/chrome/content/browser.js

RESOLVED FIXED in Firefox 68

Status

()

enhancement
RESOLVED FIXED
Last year
4 months ago

People

(Reporter: standard8, Assigned: championshuttler)

Tracking

unspecified
Firefox 68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

This used to be ignored because it used non-standard try/catch forms. However, these have been removed now, so we should be able to enable ESLint on this file.

The reference will need to be removed from <topsrcdir>/.eslintignore

Hi Mark , Can I take this up?

Thanks

Flags: needinfo?(standard8)

(In reply to Shivam Singhal [ :championshuttler ] from comment #1)

Hi Mark , Can I take this up?

Sure, but don't forget the other bugs you're assigned to as well...

Flags: needinfo?(standard8)
Attachment #9049868 - Attachment description: Bug 1484640 - Enable ESLint for mobile/android/chrome/content/browser.js. (Manual Changes). r=standard8 → Bug 1484640 - Enable ESLint for mobile/android/chrome/content/browser.js (Manual Changes). r=standard8
Assignee: nobody → shivams2799
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: checkin-needed
Keywords: checkin-needed
Whiteboard: checkin-needed
Keywords: checkin-needed
Whiteboard: checkin-needed

This failed to land:

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmp23IH2N\npatching file mobile/android/chrome/content/browser.js\nHunk #25 FAILED at 1319\n1 out of 162 hunks FAILED -- saving rejects to file mobile/android/chrome/content/browser.js.rej\nabort: patch failed to apply', '')

Flags: needinfo?(shivams2799)
Keywords: checkin-needed
Whiteboard: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/5914426902ac
Enable ESLint for mobile/android/chrome/content/browser.js (Automatic Changes). r=snorp
https://hg.mozilla.org/integration/autoland/rev/54f421232d08
Enable ESLint for mobile/android/chrome/content/browser.js (Manual Changes). r=snorp
Attachment #9049868 - Attachment is obsolete: true
Attachment #9049867 - Attachment is obsolete: true

@Standard8 Sorry for that , made changes and made new revisions

Thanks

Flags: needinfo?(shivams2799) → needinfo?(standard8)

Could you try pushing the changes to the existing commits? That would make it easier.

You should just be able to edit the commit messages of both commits, and change the differential revision to point at the old Dnnnn numbers, then push again (you can un-abandon revisions).

Flags: needinfo?(standard8)
Attachment #9049867 - Attachment is obsolete: false
Attachment #9049868 - Attachment is obsolete: false
Attachment #9052504 - Attachment is obsolete: true
Attachment #9052505 - Attachment is obsolete: true

@Standard8 Made the changes. Thanks

Attachment #9052505 - Attachment is obsolete: false
Attachment #9052505 - Attachment is obsolete: true
Keywords: checkin-needed
Whiteboard: checkin-needed

What exactly needs to land here?

Lando is blocked: https://irccloud.mozilla.com/file/PUOG6kdJ/lando.jpg

Flags: needinfo?(shivams2799)
Keywords: checkin-needed
Whiteboard: checkin-needed

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:championshuttler, could you have a look please?

Flags: needinfo?(shivams2799)

I've rebased the patches and fix the bitrot as I'm not sure Shivam is active at the moment. I'll push this to try, then hopefully push to autoland.

Flags: needinfo?(shivams2799)

Hi Mark,

Thanks for doing this,I did not know the reason why lando raised this error really. I am not active for some, have university exams :(

Thanks

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ad266f5412e
Enable ESLint for mobile/android/chrome/content/browser.js (Automatic Changes). r=snorp
https://hg.mozilla.org/integration/autoland/rev/8f826767d3d6
Enable ESLint for mobile/android/chrome/content/browser.js (Manual Changes). r=snorp
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.