Closed Bug 1484653 Opened 6 years ago Closed 6 years ago

[de-xbl] Remove modevbox and modehbox

Categories

(Calendar :: General, defect)

Product:
Calendar
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: arshad, Assigned: arshad)

References

Details

Attachments

(1 file, 1 obsolete file)

modevbox_modehbox_patch.patch
4.48 KB, patch
Fallen
: review+
mkmelin
: feedback+
Details | Diff | Splinter Review
Attached patch modevbox_modehbox_patch.diff (obsolete) — — Splinter Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36
Flags: needinfo?(mkmelin+mozilla)
Attachment #9002411 - Attachment is patch: true
Attachment #9002411 - Attachment mime type: text/x-patch → text/plain
Flags: needinfo?(mkmelin+mozilla)
Component: Untriaged → General
Product: Thunderbird → Calendar
Assignee: nobody → arshdkhn1
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9002411 - Flags: review?(philipp)
Summary: Remove modevbox and modehbox → [de-xbl] Remove modevbox and modehbox
Blocks: tb-war-on-xbl
Comment on attachment 9002411 [details] [diff] [review] modevbox_modehbox_patch.diff Review of attachment 9002411 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. But, it seems to me you could remove modehbox altogether (making it just modebox), since horizontal is the default orientation anyway.
Attachment #9002411 - Flags: feedback+
(In reply to Magnus Melin from comment #1) > Comment on attachment 9002411 [details] [diff] [review] > modevbox_modehbox_patch.diff > > Review of attachment 9002411 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good to me. > But, it seems to me you could remove modehbox altogether (making it just > modebox), since horizontal is the default orientation anyway. what about removing modebox instead of modehbox? modehbox is more verbose in terms of what it does.
Removed modehbox as per your comment.
Attachment #9002411 - Attachment is obsolete: true
Attachment #9002411 - Flags: review?(philipp)
Attachment #9004951 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9004951 [details] [diff] [review] modevbox_modehbox_patch.patch Review of attachment 9004951 [details] [diff] [review]: ----------------------------------------------------------------- Yep looks good to me. calendar/ so r? -> philipp
Attachment #9004951 - Flags: review?(philipp)
Attachment #9004951 - Flags: review?(mkmelin+mozilla)
Attachment #9004951 - Flags: feedback+
Attachment #9004951 - Flags: review?(philipp) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/b2f73a356bde Remove modehbox and modevbox bindings. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
In the future, can you please provide patches with complete commit messages: Bug NNN - do/done this or that. r=reviewer
Target Milestone: --- → 6.6
Version: unspecified → Trunk
See Also: → 1512807
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: