1484739 - Use tc-lib-pulse in tc-web-server

Status: RESOLVED FIXED

(Taskcluster :: UI, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

From Eli:

@djmitche in 65a68ac[1] I attempted to switch out the PulseListener for the new implementation from taskcluster-lib-pulse, but I couldn't seem to get it to work right, so I think I'm doing something wrong. Is there any chance you could take a look and see what could be wrong here?

[1] https://github.com/taskcluster/taskcluster-web-server/commit/65a68ac369938c051ebe05eb29b50f75d3aedf37

---

Hassan, any idea where this is at?  And priority?  I've not worked with tc-web yet, but I should.  I also have about 200 tasks in front of this one in Taskwarrior.. but if this can wait, maybe it's a good way for me to get started?

Comment 1

[Hassan Ali (:hassan)]

This is definitely a good way for you to get started. The priority for this one is low but would be awesome if we can have it done by the end of the quarter. The README should cover everything to get you started and also includes a sample subscription query[1]. Once you have the web server running, you can access the playground at http://localhost:3050/playground. Let me know if there is anything else I can help with.

[1] https://github.com/taskcluster/taskcluster-web-server/blob/master/README.md#sample-subscriptions

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

I made a bit of progress on writing a good solution here, but getting it to pass lint is proving difficult, so I haven't been able to run it yet.

Comment 3

[Hassan Ali (:hassan)]

Great to hear! Auto linting has been removed in https://github.com/taskcluster/taskcluster-web-server/commit/10befd2ea1ddf9a7c0c63a28e631601e024db006.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Some progress here..

  https://github.com/taskcluster/taskcluster-web-server/compare/master...djmitche:bug1484739?expand=1

It seems that the "Pulse Inspector" tool doesn't work at all yet?  It doesn't appear to use any GraphQL.  Also, the PulseEngine is not providing the routes, which it needs to display.  We can likely deal with all of that when it comes time to update that tool.

Comment 5

[Hassan Ali (:hassan)]

Right, the basic UI skeleton for the pulse messages view is there but none of the GraphQL stuff is wired. I can take care of that once the backend aspect of it has been merged.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Blocked on https://github.com/taskcluster/taskcluster-lib-pulse/pull/12/files for the moment.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster-web-server/pull/28