Closed Bug 1484946 Opened 2 years ago Closed 2 years ago

Tree twisty in in-content pages has incorrect color when row is selected and unfocused

Categories

(Toolkit :: Themes, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: ntim, Assigned: arshadkazmi42)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

No description provided.
Component: Theme → Themes
Product: Firefox → Toolkit
Is this a regression from bug 1469287?
Flags: needinfo?(ntim.bugs)
(In reply to Dão Gottwald [::dao] from comment #1)
> Is this a regression from bug 1469287?

Probably not. The twisty styling was more of less broken in the in-content pages before bug 1469287.
No longer blocks: 1469287
Depends on: 1469287
Flags: needinfo?(ntim.bugs)
Priority: -- → P3
To fix this bug, you’ll need to add xul|treechildren::-moz-tree-twisty and xul|treechildren::-moz-tree-twisty(selected) to the respective rules here: https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/toolkit/themes/shared/in-content/common.inc.css#783-790

You’ll also need to remove this line: https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/toolkit/themes/shared/in-content/common.inc.css#716
Keywords: good-first-bug
Is it open for grab, I can take this up
Flags: needinfo?(ntim.bugs)
Yes, I've assigned the bug to you.
Assignee: nobody → arshadkazmi42
Flags: needinfo?(ntim.bugs)
Attachment #9016992 - Attachment description: Tree twisty in content pages will show correct colors when selected and unfocussed → Tree twisty in content pages will show correct colors when selected and unfocused
Attachment #9016992 - Attachment description: Tree twisty in content pages will show correct colors when selected and unfocused → Bug 1484946 - Fix tree twisty color on in-content pages when selected and unfocused
Attachment #9016992 - Flags: review?(dao+bmo)
Attachment #9016992 - Flags: review?(dao+bmo)
Thanks Tim and Dao for the review
Keywords: checkin-needed
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab9dfffff004
Fix tree twisty color on in-content pages when selected and unfocused r=ntim,dao
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ab9dfffff004
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.