1484946 - Tree twisty in in-content pages has incorrect color when row is selected and unfocused

Status: RESOLVED FIXED

(Toolkit :: Themes, defect, P3)

Comment 1

[Dão Gottwald [:dao]]

Is this a regression from bug 1469287?

Comment 2

[Tim Nguyen :ntim]

(In reply to Dão Gottwald [::dao] from comment #1)
> Is this a regression from bug 1469287?

Probably not. The twisty styling was more of less broken in the in-content pages before bug 1469287.

Comment 3

[Tim Nguyen :ntim]

To fix this bug, you’ll need to add xul|treechildren::-moz-tree-twisty and xul|treechildren::-moz-tree-twisty(selected) to the respective rules here: https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/toolkit/themes/shared/in-content/common.inc.css#783-790

You’ll also need to remove this line: https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/toolkit/themes/shared/in-content/common.inc.css#716

Comment 4

[Arshad Kazmi [:arshadkazmi42]]

Is it open for grab, I can take this up

Comment 5

[Tim Nguyen :ntim]

Yes, I've assigned the bug to you.

Comment 6

[Arshad Kazmi [:arshadkazmi42]]

Attachment: Bug 1484946 - Fix tree twisty color on in-content pages when selected and unfocused

Comment 7

[Arshad Kazmi [:arshadkazmi42]]

Thanks Tim and Dao for the review

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab9dfffff004
Fix tree twisty color on in-content pages when selected and unfocused r=ntim,dao

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ab9dfffff004