148495 - Download manager shows an empty tooltip

Status: VERIFIED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Koike Kazuhiko]

If you close the toolbar on Download Manager and move the mouse pointer
over the closed toolbar, an empty tooltip appears.

Screenshot:
http://bugzilla.mozilla.gr.jp/showattachment.cgi?attach_id=794

Comment 1

[Frederic Bezies]

Confirming it - build 200203106 - WinXP.

Comment 2

[Kai Lahmann (is there, where MNG is)]

build 2002052421/LInux - see it too

Comment 3

[Mike Kowalski]

Attachment: fix

Comment 4

[Daniel Brooks [:db48x]]

Comment on attachment 89519 [details] [diff] [review]
fix

cool.
r=db48x

Comment 5

[Mike Kowalski]

Comment on attachment 89519 [details] [diff] [review]
fix

blake says sr=me on IRC.

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

This patch is incorrect.

In downloadmanager.xul:

-    <toolbarr id="download-toolbar" tbalign="stretch"
class="chromeclass-toolbar" persist="collapsed">
+    <toolbar id="download-toolbar" tbalign="stretch"
class="chromeclass-toolbar" persist="collapsed" grippytooltiptext="&dm.tooltip;"/>

you've closed the toolbar, then it's closed later, again:

Lines 124-125:

<toolbarbutton id="btn_showinshell" command="cmd_showinshell"/>
    </toolbar>

I'll attach a new patch, can I get reviews on it?

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Fix, again

Comment 8

[Daniel Brooks [:db48x]]

Comment on attachment 90149 [details] [diff] [review]
Fix, again

/me sighs. such a silly thing to miss. r=db48x, again

Comment 9

[jag (Peter Annema)]

Comment on attachment 90149 [details] [diff] [review]
Fix, again

sr=jag

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Fixed on trunk.

Comment 11

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2002.09.19.08 comm trunk builds.