1484960 - Crash in java.lang.IllegalStateException: at org.mozilla.gecko.GeckoAppShell.setDisplayDensityOverride(GeckoAppShell.java)

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-12e7fceb-d72e-4cf8-9c65-5ea290180821.
=============================================================

java.lang.IllegalStateException
	at org.mozilla.gecko.GeckoAppShell.setDisplayDensityOverride(GeckoAppShell.java:1011)
	at org.mozilla.geckoview.GeckoRuntime.init(GeckoRuntime.java:111)
	at org.mozilla.geckoview.GeckoRuntime.getDefault(GeckoRuntime.java:54)
	at org.mozilla.geckoview.GeckoView.onAttachedToWindow(GeckoView.java:339)
	at android.view.View.dispatchAttachedToWindow(View.java:17445)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3326)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3333)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3333)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3333)
	at android.view.ViewGroup.addViewInner(ViewGroup.java:4977)
	...

=============================================================

There is 1 crash in nightly 63 with buildid 20180819100140. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1483420.

[1] https://hg.mozilla.org/mozilla-central/rev?node=b439cdd35e49

Comment 1

[Randall Barker [:rbarker]]

Jim, this looks like a race condition to me in Fennec. The only way this exception can be thrown is if GeckoAppShell.getDensity() is called before GeckoRuntime.init(); I think it can be fixed by adding a null check to GeckoAppShell.setDisplayDensityOverride() which I'll add, but the race condition in Fennec probably isn't great.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

I think it's happening because we are calling `GeckoRuntime.init()` twice -- once from `GeckoApplication.createRuntime()` and once from `GeckoRuntime.getDefault()`. I think the right solution is to unify the two sources of `GeckoRuntime`, so that `GeckoRuntime.getDefault`, in Fennec, will return the same runtime created by `GeckoApplication`.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Randall Barker [:rbarker] from comment #1)
> Jim, this looks like a race condition to me in Fennec. The only way this
> exception can be thrown is if GeckoAppShell.getDensity() is called before
> GeckoRuntime.init(); I think it can be fixed by adding a null check to
> GeckoAppShell.setDisplayDensityOverride() which I'll add, but the race
> condition in Fennec probably isn't great.

Adding a null-check in `setDisplayDensityOverride` will defeat the purpose of this exception, which is to catch double-calling situations like this, right?

Comment 4

[Randall Barker [:rbarker]]

Attachment: Bug 1484960 - Remove IllegalStateException throw on multiple calls to overrides in GeckoAppShell r=jchen

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9002868 [details]
Bug 1484960 - Remove IllegalStateException throw on multiple calls to overrides in GeckoAppShell r=jchen

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d09209d2ee1
Remove IllegalStateException throw on multiple calls to overrides in GeckoAppShell r=jchen

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8d09209d2ee1