1485114 - Avoid creating nsPermission objects in the permission manager needlessly

Status: RESOLVED FIXED

(Core :: Permission Manager, enhancement)

Comment 1

[(no longer active)]

Attachment: Avoid creating nsPermission objects in the permission manager needlessly

Comment 2

[(no longer active)]

Attachment: Avoid creating nsPermission objects in the permission manager needlessly

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 9002879 [details] [diff] [review]
Avoid creating nsPermission objects in the permission manager needlessly

Review of attachment 9002879 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/cookie/nsPermissionManager.cpp
@@ +2705,5 @@
>  
>  nsresult
>  nsPermissionManager::RemovePermissionsWithAttributes(mozilla::OriginAttributesPattern& aPattern)
>  {
> +  AutoTArray<Pair<nsCOMPtr<nsIPrincipal>, nsCString>, 10> permissions;

It's a shame this one is still not using the common code. I presume this was to avoid double-parsing the nsIPrincipal?

Comment 4

[(no longer active)]

(In reply to :Nika Layzell (digging out of backlog) from comment #3)
> Comment on attachment 9002879 [details] [diff] [review]
> Avoid creating nsPermission objects in the permission manager needlessly
> 
> Review of attachment 9002879 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: extensions/cookie/nsPermissionManager.cpp
> @@ +2705,5 @@
> >  
> >  nsresult
> >  nsPermissionManager::RemovePermissionsWithAttributes(mozilla::OriginAttributesPattern& aPattern)
> >  {
> > +  AutoTArray<Pair<nsCOMPtr<nsIPrincipal>, nsCString>, 10> permissions;
> 
> It's a shame this one is still not using the common code. I presume this was
> to avoid double-parsing the nsIPrincipal?

More because this function filters the principals stored in the permission table, but RemovePermissionEntries() filters the permission entries for each principal in the permission table.  IOW the filtering happens at different levels between the two.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b2e26f618a4
Avoid creating nsPermission objects in the permission manager needlessly; r=nika

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9b2e26f618a4