Closed Bug 1485114 Opened 4 years ago Closed 4 years ago

Avoid creating nsPermission objects in the permission manager needlessly

Categories

(Core :: Permission Manager, enhancement)

Product:
Core
Component:
Permission Manager
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(1 file, 1 obsolete file)

Avoid creating nsPermission objects in the permission manager needlessly
5.20 KB, patch
nika
: review+
Details | Diff | Splinter Review 
No description provided.
Assignee: nobody → ehsan
Attachment #9002877 - Attachment is obsolete: true
Attachment #9002879 - Flags: review?(nika)
Attachment #9002877 - Flags: review?(nika)
Comment on attachment 9002879 [details] [diff] [review]
Avoid creating nsPermission objects in the permission manager needlessly

Review of attachment 9002879 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/cookie/nsPermissionManager.cpp
@@ +2705,5 @@
>  
>  nsresult
>  nsPermissionManager::RemovePermissionsWithAttributes(mozilla::OriginAttributesPattern& aPattern)
>  {
> +  AutoTArray<Pair<nsCOMPtr<nsIPrincipal>, nsCString>, 10> permissions;

It's a shame this one is still not using the common code. I presume this was to avoid double-parsing the nsIPrincipal?
Attachment #9002879 - Flags: review?(nika) → review+
(In reply to :Nika Layzell (digging out of backlog) from comment #3)
> Comment on attachment 9002879 [details] [diff] [review]
> Avoid creating nsPermission objects in the permission manager needlessly
> 
> Review of attachment 9002879 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: extensions/cookie/nsPermissionManager.cpp
> @@ +2705,5 @@
> >  
> >  nsresult
> >  nsPermissionManager::RemovePermissionsWithAttributes(mozilla::OriginAttributesPattern& aPattern)
> >  {
> > +  AutoTArray<Pair<nsCOMPtr<nsIPrincipal>, nsCString>, 10> permissions;
> 
> It's a shame this one is still not using the common code. I presume this was
> to avoid double-parsing the nsIPrincipal?

More because this function filters the principals stored in the permission table, but RemovePermissionEntries() filters the permission entries for each principal in the permission table.  IOW the filtering happens at different levels between the two.
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b2e26f618a4
Avoid creating nsPermission objects in the permission manager needlessly; r=nika
https://hg.mozilla.org/mozilla-central/rev/9b2e26f618a4
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.