1485151 - Investigate try-with-resources for temporary strict mode exceptions

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Jan Henning [:JanH]]

I've stumbled across this in the Chromium source and it seems a nicer way of setting and resetting temporary strict mode exceptions.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1485151 - Part 1 - Import StrictModeContext from Chromium. r?jchen

Comment 2

[Jan Henning [:JanH]]

Attachment: Bug 1485151 - Part 2 - Switch our whitelisting of StrictMode violations to try-with-resources. r?jchen

In my opinion this is an altogether nicer way of setting and resetting temporary
StrictMode exceptions. The only fly in the ointment is that this causes a
warning about a technically unused variable that subsequently needs suppressing.

Comment 3

[Jan Henning [:JanH]]

Attachment: Bug 1485151 - Use UpdateServiceHelper to decide on whether to add Updater notification channel. r?jchen

That way, we only add that notification channel if the updater really is active,
i.e. not if we've been installed from the Play Store.
Unfortunately, using the UpdateServiceHelper requires a Context, so adding/re-
moving the UPDATER_CHANNEL_TAG cannot be done during variable initialisation.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9006085 [details]
Bug 1485151 - Part 1 - Import StrictModeContext from Chromium. r?jchen

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9006086 [details]
Bug 1485151 - Part 2 - Switch our whitelisting of StrictMode violations to try-with-resources. r?jchen

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 6

[Jan Henning [:JanH]]

I want to import some code from Chromium in https://phabricator.services.mozilla.com/D4888 and reference that file accordingly in the "Chromium License" part of our license.html. jchen said to run this by you as well.

Comment 7

[Mike Hoye [:mhoye]]

Per: https://chromium.googlesource.com/chromium/src/+/master/LICENSE

... the Chromium license is a standard BSD license with an additional clause saying that: "Neither the name of Google Inc. nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission."

This is certainly a restriction that we already face as an organization, and doesn't change the nature of the license as far as code re-use is concerned. This is an acceptable, MPL-compatible license, and we can re-use code licensed therein in the Mozilla codebase.

Thanks for checking.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bae80c903001
Part 1 - Import StrictModeContext from Chromium. r=jchen,mhoye
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e667a7854b6
Part 2 - Switch our whitelisting of StrictMode violations to try-with-resources. r=jchen

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2f7ed6350bf
Backed out 2 changesets on developer's request

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa6197b504ff
Part 1 - Import StrictModeContext from Chromium. r=jchen,mhoye
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f53dc79984c
Part 2 - Switch our whitelisting of StrictMode violations to try-with-resources. r=jchen

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/fa6197b504ff
https://hg.mozilla.org/mozilla-central/rev/9f53dc79984c