Closed
Bug 1485189
Opened 6 years ago
Closed 6 years ago
No one dispatches MozAutoplayMediaBlocked event
Categories
(Core :: Audio/Video: Playback, enhancement, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox-esr60 | --- | unaffected |
| firefox61 | --- | unaffected |
| firefox62 | --- | unaffected |
| firefox63 | --- | fixed |
People
(Reporter: timdream, Assigned: alwu)
References
Details
Attachments
(2 files)
Yet, CastingApp.js has an event listener unremoved. Both were added in bug 1166961. https://searchfox.org/mozilla-central/rev/3fa761ade83ed0b8ab463acb057c2cf0b104689e/mobile/android/chrome/content/CastingApps.js#105 Should the event listener be removed too? How does the current blocked UI on Fennec work? Does the UI still work with XBL controls and with UA Widget controls (with dom.ua_widget.enabled set to true or false)? I don't think we have any test coverage here. It would be great if we do.
|
Reporter | |
Comment 1•6 years ago
|
||
Perhaps this is related to recent work tracked in bug 1376321?
Blocks: block-autoplay
|
||
Comment 2•6 years ago
|
||
The dispatch was removed in bug 1463919, https://hg.mozilla.org/mozilla-central/rev/a03d5236779d Chris can you take this?
Blocks: 1463919
Rank: 15
status-firefox61:
--- → unaffected
status-firefox62:
--- → unaffected
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → unaffected
Flags: needinfo?(cpearce)
Priority: -- → P2
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → alwu
Flags: needinfo?(alwu)
|
|
Assignee | |
Comment 4•6 years ago
|
||
"blocked" event is used for testing. "MozAutoplayMediaBlocked" event is used for changing the control UI on Fennec.
|
|
Assignee | |
Comment 5•6 years ago
|
||
|
|
Assignee | |
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4785e144774e87c0950c609ea2ee0b0fcc02222d
|
||
Comment 7•6 years ago
|
||
Comment on attachment 9003920 [details] Bug 1485189 - part1 : dispatch related events when play is not allowed. Chris Pearce (:cpearce) has approved the revision.
Attachment #9003920 -
Flags: review+
|
|
Reporter | |
Comment 8•6 years ago
|
||
Comment on attachment 9003924 [details] Bug 1485189 - part2 : add test. Tim Guan-tin Chien [:timdream] (please needinfo) has approved the revision.
Attachment #9003924 -
Flags: review+
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/58fc60f3fdf1 part1 : dispatch related events when play is not allowed. r=cpearce
|
||
Comment 10•6 years ago
|
||
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc07ed4ce971 part2 : add test. r=timdream
|
||
Comment 11•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/58fc60f3fdf1 https://hg.mozilla.org/mozilla-central/rev/cc07ed4ce971
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•