Closed Bug 1485189 Opened 6 years ago Closed 6 years ago

No one dispatches MozAutoplayMediaBlocked event

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

Product:
Core
Component:
Audio/Video: Playback
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 --- fixed

People

(Reporter: timdream, Assigned: alwu)

References

Details

Attachments

(2 files)

Bug 1485189 - part1 : dispatch related events when play is not allowed.
46 bytes, text/x-phabricator-request
cpearce
: review+
Details | Review
Bug 1485189 - part2 : add test.
46 bytes, text/x-phabricator-request
timdream
: review+
Details | Review
Yet, CastingApp.js has an event listener unremoved. Both were added in bug 1166961. https://searchfox.org/mozilla-central/rev/3fa761ade83ed0b8ab463acb057c2cf0b104689e/mobile/android/chrome/content/CastingApps.js#105 Should the event listener be removed too? How does the current blocked UI on Fennec work? Does the UI still work with XBL controls and with UA Widget controls (with dom.ua_widget.enabled set to true or false)? I don't think we have any test coverage here. It would be great if we do.
Perhaps this is related to recent work tracked in bug 1376321?
Blocks: block-autoplay
The dispatch was removed in bug 1463919, https://hg.mozilla.org/mozilla-central/rev/a03d5236779d Chris can you take this?
Blocks: 1463919
Rank: 15
status-firefox61: --- → unaffected
status-firefox62: --- → unaffected
status-firefox-esr52: --- → unaffected
status-firefox-esr60: --- → unaffected
Flags: needinfo?(cpearce)
Priority: -- → P2
This looks like a job for alwu.
Flags: needinfo?(cpearce) → needinfo?(alwu)
Assignee: nobody → alwu
Flags: needinfo?(alwu)
"blocked" event is used for testing. "MozAutoplayMediaBlocked" event is used for changing the control UI on Fennec.
Comment on attachment 9003920 [details] Bug 1485189 - part1 : dispatch related events when play is not allowed. Chris Pearce (:cpearce) has approved the revision.
Attachment #9003920 - Flags: review+
Comment on attachment 9003924 [details] Bug 1485189 - part2 : add test. Tim Guan-tin Chien [:timdream] (please needinfo) has approved the revision.
Attachment #9003924 - Flags: review+
Blocks: 1487143
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/58fc60f3fdf1 part1 : dispatch related events when play is not allowed. r=cpearce
https://hg.mozilla.org/mozilla-central/rev/58fc60f3fdf1 https://hg.mozilla.org/mozilla-central/rev/cc07ed4ce971
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: