Closed Bug 1485189 Opened 3 years ago Closed 3 years ago
No one dispatches Moz
Autoplay Media Blocked event
Yet, CastingApp.js has an event listener unremoved. Both were added in bug 1166961. https://searchfox.org/mozilla-central/rev/3fa761ade83ed0b8ab463acb057c2cf0b104689e/mobile/android/chrome/content/CastingApps.js#105 Should the event listener be removed too? How does the current blocked UI on Fennec work? Does the UI still work with XBL controls and with UA Widget controls (with dom.ua_widget.enabled set to true or false)? I don't think we have any test coverage here. It would be great if we do.
The dispatch was removed in bug 1463919, https://hg.mozilla.org/mozilla-central/rev/a03d5236779d Chris can you take this?
This looks like a job for alwu.
Flags: needinfo?(cpearce) → needinfo?(alwu)
"blocked" event is used for testing. "MozAutoplayMediaBlocked" event is used for changing the control UI on Fennec.
Comment on attachment 9003920 [details] Bug 1485189 - part1 : dispatch related events when play is not allowed. Chris Pearce (:cpearce) has approved the revision.
Attachment #9003920 - Flags: review+
Comment on attachment 9003924 [details] Bug 1485189 - part2 : add test. Tim Guan-tin Chien [:timdream] (please needinfo) has approved the revision.
Attachment #9003924 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/58fc60f3fdf1 part1 : dispatch related events when play is not allowed. r=cpearce
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/cc07ed4ce971 part2 : add test. r=timdream
You need to log in before you can comment on or make changes to this bug.