Closed
Bug 1485198
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 12606 - Update audit.js and fix error catching logic in should().throw()
Categories
(Core :: Web Audio, enhancement, P4)
Core
Web Audio
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 12606 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/12606 Details from upstream follow. Hongchan Choi <hongchan@chromium.org> wrote: > Update audit.js and fix error catching logic in should().throw() > > Fetch/update audit.js in non-WPT layout tests and also fix the error > in the error catching logic in should().throw() assertion. > > The updated code checks if the |error| object passed by try/catch > is "DOMException". This is unnecessarily specific, so this CL changes > the check to look for the "Error" type, which is more generic. > > Bug: 865614 > Test: All layout tests pass. > Change-Id: I16acacb26c194a0ff950aca05e931195bf55167f > > Reviewed-on: https://chromium-review.googlesource.com/1184146 > WPT-Export-Revision: 303b6e5df79d48058c4b951b73d2d57f135ecf81
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → Web Audio
Product: Testing → Core
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=80616af74c9876d0101fede518ddb651e487f9fb
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbad96c3c949dada2bb946616a56a367d093e21d
Assignee | ||
Comment 3•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=28ece094a2f63ad823d7e3a1401c7e3bf9c8df50
Assignee | ||
Comment 4•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=63e3fa55297ce8bc94f5ff4f3df3d20a30e17836
Assignee | ||
Comment 5•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5601adb435401801a5628ee4e33f6840412db18e
Assignee | ||
Comment 6•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=61cfeb758a46c44d14b4df5b1bfa9ef70696ea58
Assignee | ||
Comment 7•6 years ago
|
||
Ran 148 tests and 3786 subtests OK : 113 PASS : 3496[linux64-debug,linux64-opt], 3499[linux32-debug,linux32-opt] FAIL : 290[linux64-debug,linux64-opt], 287[linux32-debug,linux32-opt] TIMEOUT: 3 ERROR : 32 New tests that have failures or other problems: /webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions.html # AUDIT TASK RUNNER FINISHED: 1 out of 5 tasks were failed.: FAIL < [curve lengths] 1 out of 3 assertions were failed.: FAIL
Assignee | ||
Comment 8•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=04ab5fd612bfabdfdbee952d072795cd1102e9e4
Assignee | ||
Comment 9•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ff4f8facc73734aa9fc009207997b121e3092d7
Assignee | ||
Comment 10•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3992bd4c62cff87c2f7781957b809f7d7184175
Comment 11•6 years ago
|
||
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/650ffc22e4fe [wpt PR 12606] - Fix the error catching logic of should().throw() in audit.js, a=testonly
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/650ffc22e4fe
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•