Closed Bug 1485198 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12606 - Update audit.js and fix error catching logic in should().throw()

Categories

(Core :: Web Audio, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12606 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12606
Details from upstream follow.

Hongchan Choi <hongchan@chromium.org> wrote:
>  Update audit.js and fix error catching logic in should().throw()
>  
>  Fetch/update audit.js in non-WPT layout tests and also fix the error
>  in the error catching logic in should().throw() assertion.
>  
>  The updated code checks if the |error| object passed by try/catch
>  is "DOMException". This is unnecessarily specific, so this CL changes
>  the check to look for the "Error" type, which is more generic.
>  
>  Bug: 865614
>  Test: All layout tests pass.
>  Change-Id: I16acacb26c194a0ff950aca05e931195bf55167f
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1184146
>  WPT-Export-Revision: 303b6e5df79d48058c4b951b73d2d57f135ecf81
Component: web-platform-tests → Web Audio
Product: Testing → Core
See Also: → 1472095
Ran 148 tests and 3786 subtests
OK     : 113
PASS   : 3496[linux64-debug,linux64-opt], 3499[linux32-debug,linux32-opt]
FAIL   : 290[linux64-debug,linux64-opt], 287[linux32-debug,linux32-opt]
TIMEOUT: 3
ERROR  : 32

New tests that have failures or other problems:
/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 5 tasks were failed.: FAIL
    < [curve lengths] 1 out of 3 assertions were failed.: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/650ffc22e4fe
[wpt PR 12606] - Fix the error catching logic of should().throw() in audit.js, a=testonly
https://hg.mozilla.org/mozilla-central/rev/650ffc22e4fe
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.