1485198 - [wpt-sync] Sync PR 12606 - Update audit.js and fix error catching logic in should().throw()

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 12606 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12606
Details from upstream follow.

Hongchan Choi <[e-mail]> wrote:
>  Update audit.js and fix error catching logic in should().throw()
>  
>  Fetch/update audit.js in non-WPT layout tests and also fix the error
>  in the error catching logic in should().throw() assertion.
>  
>  The updated code checks if the |error| object passed by try/catch
>  is "DOMException". This is unnecessarily specific, so this CL changes
>  the check to look for the "Error" type, which is more generic.
>  
>  Bug: 865614
>  Test: All layout tests pass.
>  Change-Id: I16acacb26c194a0ff950aca05e931195bf55167f
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1184146
>  WPT-Export-Revision: 303b6e5df79d48058c4b951b73d2d57f135ecf81

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=80616af74c9876d0101fede518ddb651e487f9fb

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbad96c3c949dada2bb946616a56a367d093e21d

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=28ece094a2f63ad823d7e3a1401c7e3bf9c8df50

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=63e3fa55297ce8bc94f5ff4f3df3d20a30e17836

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5601adb435401801a5628ee4e33f6840412db18e

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=61cfeb758a46c44d14b4df5b1bfa9ef70696ea58

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 148 tests and 3786 subtests
OK     : 113
PASS   : 3496[linux64-debug,linux64-opt], 3499[linux32-debug,linux32-opt]
FAIL   : 290[linux64-debug,linux64-opt], 287[linux32-debug,linux32-opt]
TIMEOUT: 3
ERROR  : 32

New tests that have failures or other problems:
/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurve-exceptions.html
    # AUDIT TASK RUNNER FINISHED: 1 out of 5 tasks were failed.: FAIL
    < [curve lengths] 1 out of 3 assertions were failed.: FAIL

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=04ab5fd612bfabdfdbee952d072795cd1102e9e4

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ff4f8facc73734aa9fc009207997b121e3092d7

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3992bd4c62cff87c2f7781957b809f7d7184175

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/650ffc22e4fe
[wpt PR 12606] - Fix the error catching logic of should().throw() in audit.js, a=testonly

Comment 12

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/650ffc22e4fe