Closed Bug 1485216 Opened Last year Closed 11 months ago
Thread Pool, Scheduler and Labeled Event Queue are unused
It was introduced in bug 1350432, but it was never used as far as I can tell. Should we remove it, or will it ever be used? If we plan to use it at some point and don't want it to bitrot, can we compile it in debug only so we don't pay the price for it in builds we ship to users?
Sure, we can remove it. Kind of unfortunate, but that's life. Looking at my Linux64 binary, there's only about a kilobyte of CooperativeThreadPool code, so it won't make a lot of difference either way...
I wonder if the related classes might be removed (with more effort): Scheduler, LabeledEventQueue, PrioritizedEventQueue, nsILabelableRunnable, etc.
Scheduler and LabeledEventQueue can be removed. PrioritezedEventQueue is in use, nsILabelableRunnable as well.
Are you planning on taking this on?
Summary: CooperativeThreadPool seems unused → CooperativeThreadPool, Scheduler and LabeledEventQueue are unused
I would like to take it on, yes.
We do use LabeledEventQueue, but shouldn't, since it shows up in performance profiles.
This compiles on my machine, at least. We'll see if it gets through try.
Attachment #9037678 - Flags: review?(continuation)
Attachment #9037678 - Flags: review?(continuation) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/d9cde93070b0 remove Scheduler and related code from xpcom/threads; r=mccr8
11 months ago
Assignee: nobody → nfroyd
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/784f80261f91 follow-up - really delete now-dead code; r=me
You need to log in before you can comment on or make changes to this bug.