Closed Bug 1485251 Opened 6 years ago Closed 6 years ago

can't access the site menu items by tapping three lines on upper left corner.

Categories

(Core :: Layout, defect, P3)

63 Branch
Unspecified
Android
defect

Tracking

()

RESOLVED DUPLICATE of bug 1200585
Tracking Status
firefox63 --- affected

People

(Reporter: karlcow, Unassigned)

References

()

Details

(Whiteboard: [webcompat] )

Attachments

(2 files)

This is a spin-off of https://webcompat.com/issues/14861

Not sure if it's the right component and if it's a performance issue. 

1. Go to http://www.amulyam.in/wallet-summary.do with Firefox on Android.
2. tap on the 3 lines menu

See the shadow covering the content
but the menu doesn't appear.

As said in https://webcompat.com/issues/14861

This doesn't happen if we do step by step in the debugger after setting a breakpoint in the code above `$('body').toggleClass('overflow');`

```js
  $('#mobile-nav, .back_icon').click(function (event) {
    $('nav').toggleClass('active');
    $('.nav_bg_shadow').toggle();
    $('body').toggleClass('overflow');
    if ($('#nav_section').hasClass('active')) {
      adjustSideMenuHeight();
    }
  });
```

something in `$('body').toggleClass('overflow');` is not working right.
Interesting, if one zooms in/out a bit when there is the shadow, menu is shown. Almost as if we are missing a paint.
But I don't see any reason for [qf].

Layout might be better component, assuming this is really a missing paint.
Component: DOM → Layout
Whiteboard: [webcompat] [qf] → [webcompat]
(In reply to Karl Dubost :karlcow from comment #0)
> something in `$('body').toggleClass('overflow');` is not working right.

What do the rules for .overflow have? Do they toggle overflow: hidden / overflow: auto I imagine?

A regression range or some sort of test-case would be really helpful, since this could be multiple things, from graphics, to display list stuff, to layout and overflow handling.

We do optimize <body> overflow changes a bit differently (to avoid laying out the whole page), but I think it shouldn't make a difference here...
I'm partway through to getting a reduced testcase here, FWIW.
Attached file testcase 1
2:46.86 INFO: Last good revision: 47c8e9b16918 (2013-11-03)
2:46.86 INFO: First bad revision: b4143e04bea1 (2013-11-04)
2:46.86 INFO: Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=47c8e9b16918&tochange=b4143e04bea1


Likely a regression from bug 745485. And possibly a dupe of bug 1200585.
Blocks: 745485
Attached file testcase 2
Yeah, I'm pretty sure this is a duplicate of bug 1200585. Marking as such.
No longer blocks: 745485
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: