1485264 - Rip out the dom.event.highrestimestamp.enabled pref

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement, P3)

Description

[Arthur Edelstein [:arthur]]

To improve fingerprinting resistance, Tor Browser always uses DomHighResTimeStamp instances. We set "dom.event.highrestimestamp.enabled" to true. We would like the same behavior if privacy.resistFingerprinting is enabled.

An alternative solution would be to remove the "dom.event.highrestimestamp.enabled" pref altogether.

Comment 1

[Tom Ritter [:tjr]]

It's been several years; can we rip out the dom.event.highrestimestamp.enabled pref at this point?

Comment 2

[Thorin [:thorin]]

+1: rip it out. I know it's only exposed in about:config, but misinformed users can/do get the wrong impression and disable it believing they have reduced FP'ing. It's kind of an oxymoronic(?) name when paired with FP'ing.

Comment 3

[Jay Zuo]

Willing to take a look

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Happy to review.

https://searchfox.org/mozilla-central/search?q=dom.event.highrestimestamp.enabled&path=
and
https://searchfox.org/mozilla-central/search?q=symbol:_ZN7mozilla3domL23sReturnHighResTimeStampE&redirect=false
can be useful

Comment 5

[Josef Citrine (:jcit)]

Currently looking into this. Could this be assigned to me?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Sure. Happy to review the patch.

Comment 7

[Josef Citrine (:jcit)]

Attachment: Bug 1485264 - Removed dom.event.highrestimestamp.enabled pref

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Btw, just hint if you need someone to land the change :)
Thanks for fixing this.

Comment 9

[Josef Citrine (:jcit)]

Still not entirely familiar with landing changes, do I need to mark the issue as resolved now?

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

If you push the final patch to phabricator, I think I can land it there using Lando (assuming you don't have rights to use that).

Comment 11

[Josef Citrine (:jcit)]

Ok, just pushed the final version. Hopefully that should be it

Comment 12

[Andrew McCreight [:mccr8]]

In general, you can set the checkin-needed keyword and it will be landed for you. The bug will be closed once the patch merges to mozilla-central. (Initially, it will land on an integration branch.)

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/47629d4e3150
Removed dom.event.highrestimestamp.enabled pref r=smaug

Comment 14

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/47629d4e3150

Comment 15

[Ethan Tseng [:ethan]]

Josef, thank you for fixing this!