1485291 - Use native icons for fullscreen window controls on Linux

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P3)

Comment 1

[Tim Nguyen :ntim]

Attachment: close-16.svg

Comment 2

[Tim Nguyen :ntim]

Attachment: restore.svg

Comment 3

[Tim Nguyen :ntim]

Attachment: minimize.svg

Comment 4

[Tim Nguyen :ntim]

Attachment: After

Comment 5

[Tim Nguyen :ntim]

Attachment: Use Photon icons for Minimize, Maximize, Close icons on Linux. ui-

Comment 6

[Tim Nguyen :ntim]

Attachment: Before

Comment 7

[Amin Al Hazwani [:amin] (Firefox UX)]

Comment on attachment 9003076 [details]
After

Tim, in this specific case it's not recommended to change the native max/min/close icons in favor of the Photon ones as those icons are use throughout the OS.

Comment 8

[Dão Gottwald [:dao]]

(In reply to Amin Al Hazwani [:amin] (Firefox UX) from comment #7)
> Comment on attachment 9003076 [details]
> After
> 
> Tim, in this specific case it's not recommended to change the native
> max/min/close icons in favor of the Photon ones as those icons are use
> throughout the OS.

This bug lacks some context. First of all, this is only about the custom controls we display when the window is in fullscreen mode (as opposed to windowed / maximized). Secondly, the current icons aren't native on Linux, we just copied them from Windows.

Comment 9

[Amin Al Hazwani [:amin] (Firefox UX)]

Thanks for the context Dao, I'll look more into it!

Comment 10

[Amin Al Hazwani [:amin] (Firefox UX)]

Tim, I looked into this and if possible I would use the same GTK-based distro buttons as the OS. Is that possible?

Comment 11

[Dão Gottwald [:dao]]

It's possible... Fixing bug 1356920 should make that easier.

Comment 16

[B.J. Herbison]

Now the full-screen window control match the windowed window controls with browser.tabs.drawInTitlebar true, but for XFCE those controls aren't the same as for windowed mode with browser.tabs.drawInTitlebar false. The browser.tabs.drawInTitlebar false window controls match other XFCE windows.

This XFCE issue is covered in bug 1521925.