1485324 - Font editor: remove obsolete code once feature reaches Firefox stable.

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Razvan Caliman [:rcaliman]]

The Font Editor feature replaces the Font Inspector.

Once the Font Editor reaches Firefox Stable:
- remove the pref flag: devtools.inspector.fonteditor.enabled
- cleanup tests to not require the pref
- remove obsolete font inspector code
- remove font inspector test: client/inspector/fonts/test/browser_fontinspector_other-fonts.js
- cleanup client/inspector/fonts/test/head.js

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1485324 - (Part 1) Remove pref for Font Editor and obsolete conditionals; r=gl

This patch removes the devtools.inspector.fonteditor.enabled pref and all its uses in the Fonts panel.
Obsolete actions for the case when the pref was off are also removed. This is mostly old font inspector code.

One test is temporarily disabled because it tests the old font inspector. It will be removed along with other
pieces on the next part of this commit series.

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1485324 - (Part 2) Remove obsolete subset of fonts not used on current element; r=gl

Depends on D11505
The `otherFonts` field in the Redux store slice for Fonts was used by the old Font Inspector to differentiate
between fonts on the element and fonts elsewhere on the page. This is no longer used with the Font Editor.

Comment 3

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1485324 - (Part 3) Remove obsolete font on element no longer used in Fonts panel; r=gl

Depends on D11506
Removes the `fonts` field from the Redux slice previously used by the FontOverview component
in the Font Inspector version of the Fonts panel. This field is duplicated with the `fonts`
used by the Font Editor. The telemetry can use that one instead.

Refactors the update() method which updates the Redux slice for the FontOverview component.
In time, the update() and refreshFontEditor() method will merge. So will the Redux slices:
`fontEditor` and `fonts` in order to save a duplicate call to the server for `allFonts`.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd1eadadbeeb
(Part 1) Remove pref for Font Editor and obsolete conditionals; r=gl
https://hg.mozilla.org/integration/autoland/rev/13a15cc93107
(Part 2) Remove obsolete subset of fonts not used on current element; r=gl
https://hg.mozilla.org/integration/autoland/rev/003af6524115
(Part 3) Remove obsolete font on element no longer used in Fonts panel; r=gl

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/dd1eadadbeeb
https://hg.mozilla.org/mozilla-central/rev/13a15cc93107
https://hg.mozilla.org/mozilla-central/rev/003af6524115