1485340 - URL parsing uses isdigit() and isxdigit()

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

Per https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/isdigit-iswdigit-isdigit-l-iswdigit-l these are locale-dependent on Windows and https://stackoverflow.com/questions/2898228/can-isdigit-legitimately-be-locale-dependent-in-c gives an example of how.

mozilla::IsAsciiDigit() should be used in place of isdigit() and an analog of isxdigit() needs to be introduced in mfbt/TextUtils.h.

Comment 1

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

mozilla::IsAsciiHexDigit() is coming in bug 1421501.

Comment 2

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-04-13)]

Attachment: Bug 1485340 - Avoid isdigit() and isxdigit() in URL parsing.

MozReview-Commit-ID: 13DUMcZIE19

Comment 3

[Valentin Gosu [:valentin] {{ PTO 2 - 12 April }}]

Comment on attachment 9004140 [details]
Bug 1485340 - Avoid isdigit() and isxdigit() in URL parsing.

Valentin Gosu [:valentin] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be9a86909487
Avoid isdigit() and isxdigit() in URL parsing. r=valentin

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/be9a86909487