1485378 - CallWatcher actor is registered as target scoped actor but doesn't need to be

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P4)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

https://searchfox.org/mozilla-central/rev/3fa761ade83ed0b8ab463acb057c2cf0b104689e/devtools/server/main.js#331-334
    this.registerModule("devtools/server/actors/call-watcher", {
      prefix: "callWatcher",
      constructor: "CallWatcherActor",
      type: { target: true }
    });

This actor is registered as a Target scoped actor, but noone tries to instanciate it from the client:
https://searchfox.org/mozilla-central/search?q=CallWatcherFront(&case=false&regexp=false&path=

Only tests do.

1) We should stop registering it as a target scoped. It would break this tests:
   https://searchfox.org/mozilla-central/source/devtools/client/canvasdebugger/test/browser_canvas-actor-test-02.js#10
  So we may register it only for tests? or tweak the test somehow?

2) If you ignore the test, CallWatcherActor isn't directly used by the client. So it is rather an actor helper class than an actor/front.
We exposes "call-watcher" and "function-call", but only "function-call" type is used by the client:
  https://searchfox.org/mozilla-central/rev/3fa761ade83ed0b8ab463acb057c2cf0b104689e/devtools/shared/specs/index.js#56-60
  We should only export function-call here.
  See the various attributes or method of this actor, it only appears in actor codebase or the test:
  https://searchfox.org/mozilla-central/source/devtools/shared/specs/call-watcher.js#39-77
  https://searchfox.org/mozilla-central/search?q=symbol:%23tracedGlobals&redirect=false
  https://searchfox.org/mozilla-central/search?q=symbol:%23initTimestampEpoch&redirect=false
  ...
  But function-call actor is actually used by the client, so this is a real actor and justify a spec and a front:
  https://searchfox.org/mozilla-central/source/devtools/shared/specs/call-watcher.js#31
  https://searchfox.org/mozilla-central/search?q=symbol%3A%23getDetails&case=false&regexp=false&path=devtools

Comment 1

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1485378 - Replace CallWatcher actor with helper; r=jdescottes

creates a CallWatcherActor only for tests and migrates other functionality to the helper

Comment 2

[Yulia Startsev [:yulia] OOO until July 2026]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1322e813d93addd830780f0a8fb530eee6c6f77c

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 9008066 [details]
Bug 1485378 - Replace CallWatcher actor with helper; r=jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.

Comment 4

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: Bug 1485378 - Replace CallWatcher actor with helper; r=jdescottes

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93d1ad43e3d3
Replace CallWatcher actor with helper; r=jdescottes

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/93d1ad43e3d3