1485414 - Unused macro_use for lazy_static in webdriver crate

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

From build:

>    Compiling webdriver v0.36.0 (file:///home/ato/src/gecko/testing/webdriver)
> warning: unused `#[macro_use]` import
>  --> testing/webdriver/src/lib.rs:5:1
>   |
> 5 | #[macro_use]
>   | ^^^^^^^^^^^^
>   |
>   = note: #[warn(unused_imports)] on by default

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Drop unused macro_use for lazy_static.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Comment on attachment 9003203 [details] [diff] [review]
Drop unused macro_use for lazy_static.

Review of attachment 9003203 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/webdriver/src/lib.rs
@@ -1,5 @@
>  #![allow(non_snake_case)]
>  
>  extern crate base64;
>  extern crate cookie;
> -#[macro_use]

This line cannot be removed because it is used in test.rs. Note that `cargo test` will fail.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: Drop unused macro_use for lazy_static.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Comment on attachment 9003400 [details] [diff] [review]
Drop unused macro_use for lazy_static.

Review of attachment 9003400 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, and please update the commit message.

Comment 5

[Andreas Tolfsen ❲:ato❳]

What’s wrong with the commit message?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

You don't drop it, but move it.

Comment 7

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #6)
> You don't drop it, but move it.

Ah, that’s right.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/63e890c419e8
Make lazy_static a dev dependency. r=whimboo

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/63e890c419e8