Closed Bug 1485414 Opened 5 years ago Closed 5 years ago

Unused macro_use for lazy_static in webdriver crate

Categories

(Testing :: geckodriver, enhancement)

Product:
Testing
Component:
geckodriver
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(1 file, 1 obsolete file)

Drop unused macro_use for lazy_static.
1.52 KB, patch
whimboo
: review+
Details | Diff | Splinter Review 
From build:

>    Compiling webdriver v0.36.0 (file:///home/ato/src/gecko/testing/webdriver)
> warning: unused `#[macro_use]` import
>  --> testing/webdriver/src/lib.rs:5:1
>   |
> 5 | #[macro_use]
>   | ^^^^^^^^^^^^
>   |
>   = note: #[warn(unused_imports)] on by default
Assignee: nobody → ato
Status: NEW → ASSIGNED

        Attachment #9003203 -
        Flags: review?(hskupin)

    
    

    
  
Comment on attachment 9003203 [details] [diff] [review]
Drop unused macro_use for lazy_static.

Review of attachment 9003203 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/webdriver/src/lib.rs
@@ -1,5 @@
>  #![allow(non_snake_case)]
>  
>  extern crate base64;
>  extern crate cookie;
> -#[macro_use]

This line cannot be removed because it is used in test.rs. Note that `cargo test` will fail.

        Attachment #9003203 -
        Flags: review?(hskupin) → review-

    
    

    
  


  

        Attachment #9003400 -
        Flags: review?(hskupin)

    
  

        Attachment #9003203 -
        Attachment is obsolete: true

        Attachment #9003400 -
        Flags: review?(hskupin) → review+

    
    

    
  
Comment on attachment 9003400 [details] [diff] [review]
Drop unused macro_use for lazy_static.

Review of attachment 9003400 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, and please update the commit message.

    
    

    
  
What’s wrong with the commit message?
Flags: needinfo?(hskupin)

    
    

    
  
You don't drop it, but move it.
Flags: needinfo?(hskupin)

    
    

    
  
(In reply to Henrik Skupin (:whimboo) from comment #6)
> You don't drop it, but move it.

Ah, that’s right.

    
    

    
  
Pushed by ato@sny.no:
https://hg.mozilla.org/integration/mozilla-inbound/rev/63e890c419e8
Make lazy_static a dev dependency. r=whimboo

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/63e890c419e8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago

          status-firefox63:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63

          You need to log in
          before you can comment on or make changes to this bug.