Open Bug 1485457 Opened 6 years ago Updated 3 months ago

Move ArrayIterator and StringIterator code from js/src/vm/Iteration.{h,cpp} into js/src/builtin

Categories

(Core :: JavaScript: Standard Library, enhancement, P3)

enhancement

Tracking

()

Tracking Status
firefox63 --- affected

People

(Reporter: anba, Unassigned)

References

(Blocks 1 open bug)

Details

(In reply to Jason Orendorff [:jorendorff] from bug 1435829, comment #5) > Please put all this somewhere in js/src/builtin, since it is standard > library stuff, not part of the VM. > > It's a little odd for GlobalObject::initRegExpStringIteratorProto to live in > a different directory, but we already do that for some builtin objects: > https://searchfox.org/mozilla-central/ > search?q=%5EGlobalObject%3A%3Ainit%5Cw%2B&case=false&regexp=true&path=js%2Fsr > c%2Fbuiltin > > I hope this is not onerous. (It's so hard to tell when something like this > will be.) A separate patch would be fine, and if it's a pain, just file a > followup bug... (In reply to André Bargull [:anba] from bug 1435829, comment #11) > js/src/vm/Iteration.{h,cpp} currently also contains Array and String > iterators and the Iterator prototype object [1]. Do you think it's > acceptable to have a single js/src/builtin/Iterators.{h,cpp} file or do you > prefer separate files for each iterator class? > > [1] > https://searchfox.org/mozilla-central/source/js/src/vm/Iteration.cpp#1035- > 1097,1370-1435 (In reply to André Bargull [:anba] from bug 1435829, comment #12) > Or alternatively we can place the code in js/src/{Array,String,RegExp}.cpp > so it matches the code organisation in js/src/{Array,String,RegExp}.js.
Priority: -- → P3
Severity: normal → S3
Blocks: sm-api
Severity: S3 → N/A
You need to log in before you can comment on or make changes to this bug.