1485590 - NSPR uses isdigit()

Status: NEW

(NSPR :: NSPR, defect, P2)

Description

[Henri Sivonen (:hsivonen)]

NSPR uses isdigit():
https://searchfox.org/mozilla-central/search?q=isdigit&case=true&regexp=false&path=nsprpub

Per https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/isdigit-iswdigit-isdigit-l-iswdigit-l isdigit() locale-dependent on Windows and https://stackoverflow.com/questions/2898228/can-isdigit-legitimately-be-locale-dependent-in-c gives an example of how.

mozilla::IsAsciiDigit() should be used in place of isdigit() in C++ code, but since NSPR is C, it should probably have its own isdigit() replacement.