1485605 - Remove usages of target.window

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P2)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

At first sight, it looks like there is only two usages of target.window:
https://searchfox.org/mozilla-central/search?q=target.window&case=true&regexp=false&path=

This getter only works in non-e10s, so that it most likely throws except may be on some tests.

This bug is part of an ongoing effort to convert TabTarget to become a front and so always go throught RDP request to fetch data about the tab document.

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1485605 - Remove usages of TabTarget.window. r=yulia

This code only works on non-e10s and appear to no longer be used.

Comment 2

[Yulia Startsev [:yulia] OOO until July 2026]

Comment on attachment 9010296 [details]
Bug 1485605 - Remove usages of TabTarget.window. r=yulia

Yulia Startsev [:yulia] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a4032171aaf
Remove usages of TabTarget.window. r=yulia

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 6a4032171aaf (bug 1485605) for Eslint failure on builds/worker/checkouts/gecko/devtools/client/framework/target.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=200394676&repo=autoland&lineNumber=273

[task 2018-09-20T09:30:11.549Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2018-09-20T09:36:31.098Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/framework/target.js:7:9 | 'Ci' is assigned a value but never used. (no-unused-vars)
[task 2018-09-20T09:36:31.098Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/framework/target.js:9:7 | 'Services' is assigned a value but never used. (no-unused-vars)
[taskcluster 2018-09-20 09:36:31.451Z] === Task Finished ===
[taskcluster 2018-09-20 09:36:31.452Z] Unsuccessful task run with exit code: 1 completed in 659.449 seconds

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=6a4032171aaf33d53ad6412708bcdf5fda7cc194

Backout:
https://hg.mozilla.org/integration/autoland/rev/779ae34fb3ebeb715ace0b78350c0dbdfa0b3898

Comment 5

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Sorry, I realized after clicking in lando that eslint was orange...
I fixed it and repushed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75a963db2681
Remove usages of TabTarget.window. r=yulia

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/75a963db2681