1485673 - http-on-modify-request observers can no longer redirect tracking channels when TP is on

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[(no longer active)]

This is another regression from bug 1478539 that bug 1485182 failed to fix.  In the non-cancelled code path, we handle mAPIRedirectToURI in the beginning of OnBeforeConnect(), but I forgot to handle it in CancelForTrackingProtection() yesterday, and as a result, calling redirectTo() on a channel inside the http-on-modify-request observer notification has no effect.

Patch coming up.

Comment 1

[(no longer active)]

Attachment: Allow tracking channels being redirected from http-on-modify-request observer notifications when tracking protection is turned on

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 9003462 [details] [diff] [review]
Allow tracking channels being redirected from http-on-modify-request observer notifications when tracking protection is turned on

Review of attachment 9003462 [details] [diff] [review]:
-----------------------------------------------------------------

ups!

::: netwerk/protocol/http/nsHttpChannel.cpp
@@ +6064,5 @@
> +    // Check to see if we should redirect this channel elsewhere by
> +    // nsIHttpChannel.redirectTo API request
> +    if (mAPIRedirectToURI) {
> +        return AsyncCall(&nsHttpChannel::HandleAsyncAPIRedirect);
> +    }

and what if this is set asynchronously (while the channel was suspended?)

I think it should be ALSO in ContinueCancelledByTrackingProtection

Comment 3

[(no longer active)]

Yes, good catch!  I will add a test for that case as well.

Comment 4

[(no longer active)]

Attachment: Allow tracking channels being redirected from http-on-modify-request observer notifications when tracking protection is turned on

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d314de878fa
Allow tracking channels being redirected from http-on-modify-request observer notifications when tracking protection is turned on; r=mayhemer

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/260c51a609ae
follow-up: Fix lint failures on a CLOSED TREE

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6d314de878fa
https://hg.mozilla.org/mozilla-central/rev/260c51a609ae