Closed Bug 1485695 Opened Last year Closed Last year

Remove |uptime| from the main ping (it's not being used)

Categories

(Toolkit :: Telemetry, enhancement, P3)

enhancement
Points:
1

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox63 --- wontfix
firefox64 --- fixed

People

(Reporter: Dexter, Assigned: so61pi.re)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The main ping is reporting both "uptime" and "totalTime" (the are the same value, with different units) [1]. All the derived datasets are using "totalTime", and no derived dataset is using "uptime". "totalTime" was meant to replace "uptime".

Since we don't need "uptime", let's remove it.

[1] - https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/toolkit/components/telemetry/TelemetrySession.jsm#744-745
Setup as mentored!
Blocks: 1201022
Points: --- → 1
Flags: needinfo?(alessio.placitelli)
Priority: -- → P3
Assignee: nobody → so61pi.re
Flags: needinfo?(alessio.placitelli)
Hey Fred, Martin!

As described in comment 0 and in the fx-data-dev PSA [1], this bug is about drop the "uptime" field from the main ping. This shouldn't be a problem, as the totalTime field contains the same information with a different (higher) resolution.

I found that you both own a couple of queries that rely on the deprecated field [2][3]. Any chance you could tweak them to use totalTime instead?

[1] - https://mail.mozilla.org/pipermail/fx-data-dev/2018-August/000161.html
[2] - https://sql.telemetry.mozilla.org/queries/48557
[3] - https://sql.telemetry.mozilla.org/queries/5837
Flags: needinfo?(mlopatka)
Flags: needinfo?(fwollsen)
Feel free to remove this field. Both of the cited Re:Dash queries are no longer in use.
Flags: needinfo?(mlopatka)
In the study add-on, we already collect both "uptime" and "totalTime", so we can safely remove "uptime" from the add-on and adjust corresponding data queries as necessary, should we want to re-run the experiment in the future. Filed an issue to act as a reminder: https://github.com/motin/esper-pioneer-shield-study/issues/32
Flags: needinfo?(fwollsen)
Comment on attachment 9004078 [details]
Bug 1485695 - Remove unused uptime property from the main ping. r?Dexter

Alessio Placitelli [:Dexter] has approved the revision.
Attachment #9004078 - Flags: review+
Comment on attachment 9004078 [details]
Bug 1485695 - Remove unused uptime property from the main ping. r?Dexter

Alessio Placitelli [:Dexter] has requested changes to the revision.
Attachment #9004078 - Flags: review+
Comment on attachment 9004078 [details]
Bug 1485695 - Remove unused uptime property from the main ping. r?Dexter

Alessio Placitelli [:Dexter] has approved the revision.
Attachment #9004078 - Flags: review+
Pushed by aplacitelli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/22a22b0a2d48
Remove unused uptime property from the main ping. r=Dexter
https://hg.mozilla.org/mozilla-central/rev/22a22b0a2d48
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.