Closed Bug 1485702 Opened Last year Closed Last year
Front .search doesn't use "selectors Only" argument
46 bytes, text/x-phabricator-request
|Details | Review|
In order to support fission we will have to work around WalkerFront.search in order to make it go through all "fissioned" frames. This won't be easy and I see that a significant part of it, going through frames isn't used. So that would be great to remove it. The following code isn't used: https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/devtools/shared/fronts/inspector.js#213-217 As noone every set this attribute: https://searchfox.org/mozilla-central/search?q=selectorOnly&redirect=false At first sight, reverse is still used, but only reverse: https://searchfox.org/mozilla-central/search?q=selectorOnly&redirect=false
Assignee: nobody → poirot.alex
Comment on attachment 9003490 [details] Bug 1485702 - Remove unused WalkerFront.search's selectorsOnly argument. r=gl Gabriel [:gl] (ΦωΦ) has approved the revision.
Attachment #9003490 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/77c50281ad2b Remove unused WalkerFront.search's selectorsOnly argument. r=gl
You need to log in before you can comment on or make changes to this bug.