Closed Bug 1485702 Opened Last year Closed Last year

WalkerFront.search doesn't use "selectorsOnly" argument

Categories

(DevTools :: Inspector, enhancement)

enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission)

Attachments

(1 file)

In order to support fission we will have to work around WalkerFront.search in order to make it go through all "fissioned" frames.
This won't be easy and I see that a significant part of it, going through frames isn't used. So that would be great to remove it.

The following code isn't used:
  https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/devtools/shared/fronts/inspector.js#213-217
As noone every set this attribute:
  https://searchfox.org/mozilla-central/search?q=selectorOnly&redirect=false

At first sight, reverse is still used, but only reverse:
  https://searchfox.org/mozilla-central/search?q=selectorOnly&redirect=false
Comment on attachment 9003490 [details]
Bug 1485702 - Remove unused WalkerFront.search's selectorsOnly argument. r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.
Attachment #9003490 - Flags: review+
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77c50281ad2b
Remove unused WalkerFront.search's selectorsOnly argument. r=gl
https://hg.mozilla.org/mozilla-central/rev/77c50281ad2b
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Whiteboard: dt-fission
You need to log in before you can comment on or make changes to this bug.