1485702 - WalkerFront.search doesn't use "selectorsOnly" argument

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement)

Description

[Alexandre Poirot [:ochameau]]

In order to support fission we will have to work around WalkerFront.search in order to make it go through all "fissioned" frames.
This won't be easy and I see that a significant part of it, going through frames isn't used. So that would be great to remove it.

The following code isn't used:
  https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/devtools/shared/fronts/inspector.js#213-217
As noone every set this attribute:
  https://searchfox.org/mozilla-central/search?q=selectorOnly&redirect=false

At first sight, reverse is still used, but only reverse:
  https://searchfox.org/mozilla-central/search?q=selectorOnly&redirect=false

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1485702 - Remove unused WalkerFront.search's selectorsOnly argument. r=gl

Comment 2

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc66905b1210900c1350667f27a5dc0c34ec5104

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9003490 [details]
Bug 1485702 - Remove unused WalkerFront.search's selectorsOnly argument. r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77c50281ad2b
Remove unused WalkerFront.search's selectorsOnly argument. r=gl

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/77c50281ad2b