1485743 - "New in Nightly: Content Blocking" walk through popups step 1 and 2 shown together

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Haik Aftandilian [:haik]]

Attachment: Image with ordered sequence of screenshots

With the new "New in Nightly: Content Blocking" intro, after clicking Next on step 1, a new tab is created showing both "1 or 3" and "2 of 3" dialogs on the same page.

Additionally, after clicking "Got it" on step 3, the into went back to step 2. The second time it went to step 3, clicking "Got it" worked.

Hit on macOS 10.13.

See attached image with sequence of screenshots.

Comment 1

[François Marier [:francois]]

Johann, I assume this is something we want to fix for 63?

Comment 2

[Johann Hofmann [:johannh]]

Yes, though I assume it's only happening in private windows, is that correct?

Comment 3

[Haik Aftandilian [:haik]]

(In reply to Johann Hofmann [:johannh] from comment #2)
> Yes, though I assume it's only happening in private windows, is that correct?

Correct. I tried reproducing this on a normal window and could not.

Comment 4

[Johann Hofmann [:johannh]]

So, currently, we're not setting the "has seen the UI tour" pref in private windows, which is the reason for any issues I've seen so far. To fix this we have a bunch of options:

- Don't show the UI tour in private browsing. This would follow the previous rule of not showing the TP tour in private windows and I think it's a sensible choice, since pb mode can be an environment where users probably don't appreciate interruptions.

- Set the pref after the user has seen the tour in private windows. This would be an easy fix and we could continue showing the UI tour in private windows. This could very hypothetically leak the fact that the user visited a tracking page in private browsing, though I think that's not a very strong risk. As I mentioned above, it may be that users are more likely to just dismiss the tour when they are in private windows.

- Set an in-memory flag that only remembers the UI tour showing for the private window, to circumvent the problems described above.

IMO the first option sounds best, and I'll make a patch for that.

Comment 5

[Johann Hofmann [:johannh]]

Attachment: Bug 1485743 - Don't show the Content Blocking tour in private windows. r=francois

Comment 6

[François Marier [:francois]]

Comment on attachment 9003742 [details]
Bug 1485743 - Don't show the Content Blocking tour in private windows. r=francois

François Marier [:francois] has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/258c008b1915
Don't show the Content Blocking tour in private windows. r=francois

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/258c008b1915

Comment 9

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using Fx 63.0a1(2018-08-23) on macOS 10.13.6.
I can confirm this issue is fixed, I verified using Fx 63.0a1(2018-08-27), on Windows 10 x64, macOS 10.13 and Ubuntu 14.04 LTS.