Closed
Bug 1485845
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 12661 - RTCIceTransport: start() implementation.
Categories
(Core :: WebRTC, enhancement, P4)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 12661 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/12661 Details from upstream follow. Steve Anton <steveanton@chromium.org> wrote: > RTCIceTransport: start() implementation. > > This change implements the RTCIceTransport.start() method and > associated methods/events: addRemoteCandidate(), getRemoteCandidates(), > role, onstatechange. > > Bug: 864871 > Change-Id: Ic6ac7ce4c9ba98b1dc2610ed7847e6b9714f6c8d > Reviewed-on: https://chromium-review.googlesource.com/1161605 > WPT-Export-Revision: 3665abb911011b71fdf3992bdc1dadd96606d59e
Assignee | ||
Comment 1•6 years ago
|
||
PR 12661 applied with additional changes from upstream: 34f9b93c2749043ba68485dea92d1fb554075e60
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → WebRTC
Product: Testing → Core
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f168de53eda37b04b44c79a974b825648447a5e
Assignee | ||
Comment 3•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2983d9b569cd934cda393ebec4237750ac8f7d0a
Assignee | ||
Comment 4•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=0717aacfc935ba1075f4fcfb12371eeb1d98cd9b
Assignee | ||
Comment 5•6 years ago
|
||
Ran 1 tests and 25 subtests OK : 1 FAIL : 25 New tests that have failures or other problems: /webrtc/RTCIceTransport-extension.https.html RTCIceTransport constructor does not throw: FAIL RTCIceTransport initial properties are set: FAIL Two RTCIceTransports connect to each other: FAIL addRemoteCandidate() throws if closed: FAIL addRemoteCandidate() throws on invalid candidate: FAIL addRemoteCandidate() transitions state to 'checking' if start() had been called before: FAIL eventually transition gatheringState to 'complete': FAIL gather() returns at least one host candidate: FAIL gather() returns no candidates with { gatherPolicy: 'relay'} and no turn servers: FAIL gather() throws if called twice: FAIL gather() throws if closed: FAIL gather() transitions gatheringState to 'gathering': FAIL gather() with 2 stun servers should succeed: FAIL gather() with one turns server, one turn server, username, credential should succeed: FAIL gather() with { iceServers: null } should throw TypeError: FAIL gather() with { iceServers: undefined } should succeed: FAIL onicecandidate fires with null candidate before gatheringState transitions to 'complete': FAIL start() does not transition state to 'checking' if no remote candidates added: FAIL start() flushes remote candidates and transitions state to 'new' if later called with different remote parameters: FAIL start() sets role attribute to 'controlling': FAIL start() throws if closed: FAIL start() throws if later called with a different role: FAIL start() throws if usernameFragment or password not set: FAIL start() transitions state to 'checking' if one remote candidate had been added: FAIL start() with default role sets role attribute to 'controlled': FAIL
Assignee | ||
Comment 6•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dd34e730c41ef34371521840114aea06885d584
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/746c205985b5 [wpt PR 12661] - RTCIceTransport: start() implementation., a=testonly
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/746c205985b5
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•