Closed Bug 1485881 Opened Last year Closed Last year

Drop support for PaymentAddress.languageCode

Categories

(Core :: DOM: Web Payments, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: marcosc, Assigned: marcosc)

References

()

Details

(Keywords: dev-doc-complete, Whiteboard: [webpayments-reserve])

Attachments

(1 file, 3 obsolete files)

We don't plan in the first version to support this attribute on PaymentAddress in the way its intended. 

The attribute has been marked at risk of being removed from the spec. We should remove it from our implementation, as currently it doesn't do anything useful and could lead to interop issues.

We should reconsider it if merchants need it.
Assignee: nobody → mcaceres
Status: NEW → ASSIGNED
Priority: P3 → P1
Attached patch Remove languageCode (obsolete) — Splinter Review
Quick removal
Attachment #9004127 - Flags: review?(echuang)
Comment on attachment 9004127 [details] [diff] [review]
Remove languageCode

Review of attachment 9004127 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with removing following codes

https://searchfox.org/mozilla-central/source/dom/payments/PaymentRequestData.h#223
https://searchfox.org/mozilla-central/source/dom/payments/PaymentRequestData.cpp#814-819
Attachment #9004127 - Flags: review?(echuang) → review+
Attached patch Remove getter and member (obsolete) — Splinter Review
Carrying over r+
Oh oops, found a few other places where languageCode showed up. Sending another patch.
Attached patch The other few... (obsolete) — Splinter Review
Attachment #9004127 - Attachment is obsolete: true
Attachment #9004178 - Attachment is obsolete: true
Attachment #9004185 - Attachment is obsolete: true
Flags: qe-verify-
Keywords: checkin-needed
Sheriffs asked me to r+ the webidl change, but it isn't super clear to my why we'd
remove something which is anyhow in the spec.
Is there a spec bug to remove the attribute?
aha, in the URL :)
Comment on attachment 9004400 [details] [diff] [review]
Fix up a couple of tests

r+ for the webidl change, based on the github issue.
Need to verify it isn't in other implementations working when shipping.
Attachment #9004400 - Flags: review+
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f34f8a70ede7
Drop support for PaymentAddress.languageCode r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f34f8a70ede7
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Documentation updated and tis change is covered by my big BCD PR: https://github.com/mdn/browser-compat-data/pull/3096
You need to log in before you can comment on or make changes to this bug.