Closed Bug 14859 Opened 25 years ago Closed 25 years ago

splitting html mail quotes doesn't work

Categories

(Core :: DOM: Editor, defect, P3)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: akkzilla, Assigned: akkzilla)

References

Details

Splitting blockquotes doesn't work, because the code in nsHTMLEditRules.cpp:1467
does a case-sensitive compare which doesn't match what mail actually puts in.

Changing that line to
      if (typeAttrVal.Equals("cite", PR_TRUE, 4))
makes the node split properly (I have that fix in my tree and will check it in
when M12 opens if Joe doesn't beat me to it).

With this fix, the blockquote splits correctly, but it produces an ubercaret on
the latter node of the split.  Typing text inserts at the correct position
despite the caret.  Simon, is this caret problem already covered by existing
bugs?
Does splitting cites in the editor produce the same ubercaret?
Status: NEW → ASSIGNED
Target Milestone: M12
No: in the editor, splitting a blockquote type=cite has a different but still
incorrect behavior: it puts the caret on the first text node inside the second
blockquote node of the split, instead of around that whole blockquote.  Again,
typed text gets inserted to the right place, it's just the caret that's
misleading.
*** Bug 14221 has been marked as a duplicate of this bug. ***
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Fixed.
Akkana, is this working for you now? can you mark this verified-fixed? thanks!
Well, it's working for me (except for the caret being wrong), but this is a
user-level thing: reply to a mail message (using html compose), click somewhere
in the quoted text, and hit return, and see if it splits the quote and lets you
type in new text.  (The way it used to work was that your new text would
incorrectly be part of the quote instead of being outside the quote.)
so should we mark this verifief-fixed and file a separate bug on that
issue you are mentioning?
Mark it verified/fixed assuming you ran it and saw that it actually has been
fixed (or pass it to mail compose QA to do that), so that somebody besides a
developer should look at it and verify that it actually is fixed ...

If you want to open a bug on the caret, it's probably not a bad idea (probably
to jfrancis but maybe sfraser).
verified fixed...
Status: RESOLVED → VERIFIED
QA Contact: sujay → lchiang
You need to log in before you can comment on or make changes to this bug.