1485927 - Get rid of nsIHTMLObjectResizer.resizedObject

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

nsIHTMLObjectResizer.resizedObject is referred only by

comm-central:
https://searchfox.org/comm-central/rev/39cff66145fdfbfa785202c5b8d1c72a06034034/editor/ui/composer/content/editor.js#1924-1925
>  if (editor.resizedObject) {
>    editor.hideResizers();

BlueGriffon:
https://github.com/therealglazou/bluegriffon/blob/80f8876939e9a792db58ac9fe18f43f5b89ea589/base/content/bluegriffon/bindings/rulers.xml#L122-L123
>  if (editor.objectResizingEnabled && editor.resizedObject)
>    editor.refreshResizers();

nsIHTMLObjectResizer::HideResizers() is implemented as:
https://searchfox.org/mozilla-central/rev/c45b9755593ce6cc91f558b21e544f5165752de7/editor/libeditor/HTMLEditorObjectResizer.cpp#358-361
> NS_IMETHODIMP
> HTMLEditor::HideResizers()
> {
>   NS_ENSURE_TRUE(mResizedObject, NS_OK);

nsIHTMLObjectResizer::RefreshResizers() is implemented as:
https://searchfox.org/mozilla-central/rev/c45b9755593ce6cc91f558b21e544f5165752de7/editor/libeditor/HTMLEditorObjectResizer.cpp#215-219
> NS_IMETHODIMP
> HTMLEditor::RefreshResizers()
> {
>   // nothing to do if resizers are not displayed...
>   NS_ENSURE_TRUE(mResizedObject, NS_OK);

And nsIHTMLObjectResizer::GetResizedObject() is implemented as:
https://searchfox.org/mozilla-central/rev/c45b9755593ce6cc91f558b21e544f5165752de7/editor/libeditor/HTMLEditorObjectResizer.cpp#938-943
> NS_IMETHODIMP
> HTMLEditor::GetResizedObject(Element** aResizedObject)
> {
>   RefPtr<Element> ret = mResizedObject;
>   ret.forget(aResizedObject);
>   return NS_OK;

So, it does not make sense to check whether nsIHTMLObjectResizer.resizedObject returns non-null before calling hideResizers() nor refreshResizers().

Are you okay to remove nsIHTMLObjectResizer.resizedObject in Mozilla 64?

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I failed to set ni?...

Do you agree with removing nsIHTMLObjectResizer.resizedObject?

Comment 2

[Jorg K (CEST = GMT+2)]

Thanks for the heads-up.

(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #0)
> So, it does not make sense to check whether
> nsIHTMLObjectResizer.resizedObject returns non-null before calling
> hideResizers() nor refreshResizers().
The C-C code you pointed at is used in SM's HTML editor, not in TB.

Yes, HTMLEditor::HideResizers() just ignores a null in 'mResizedObject':
  NS_ENSURE_TRUE(mResizedObject, NS_OK);

So I don't have objections to the removal.

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

(In reply to Masayuki Nakano [:masayuki] (JST, +0900) (offline: 9/21-9/30) from comment #1)
> I failed to set ni?...
> 
> Do you agree with removing nsIHTMLObjectResizer.resizedObject?

Yes, agreed. Thanks for asking for BlueGriffon.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you for the reply. I'll remove it from m-c, thanks!

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=94aeb806d5e08a02a39f0106c4d929206614833a

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1485927 - Get rid of nsIHTMLObjectResizers.resizedObject

nsIHTMLObjectResizers.resizedObject is used only for avoiding warning of
nsIHTMLObjectResizers.refreshResizers() if resizers are not visible.
Therefore, if we remove the unnecessary warnings, we can get rid of the
attribute.

Comment 7

[Makoto Kato [:m_kato]]

Comment on attachment 9007768 [details]
Bug 1485927 - Get rid of nsIHTMLObjectResizers.resizedObject

Makoto Kato [:m_kato] has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd66e63ffd37
Get rid of nsIHTMLObjectResizers.resizedObject r=m_kato

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/bd66e63ffd37